From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29F7AC433E3 for ; Fri, 15 May 2020 15:00:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 142C0207C4 for ; Fri, 15 May 2020 15:00:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726610AbgEOPAj (ORCPT ); Fri, 15 May 2020 11:00:39 -0400 Received: from mga02.intel.com ([134.134.136.20]:52670 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726174AbgEOPAg (ORCPT ); Fri, 15 May 2020 11:00:36 -0400 IronPort-SDR: lm38IzyeuYoWTXcFTI2oNYDdiZ8+7f4oY7B2iujOQvivT9wERmzGZw2EPg5cQOHovJcWfj3LUo kOTx3feu6//A== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2020 08:00:36 -0700 IronPort-SDR: HSjIdpF/nRZGCr9SJb8mEf4rh552y15IUtOVwWugyT0lBpAgNRZRf9Bw5E4bPvIRTnXLfZDfho y39by4V9ZCyg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,395,1583222400"; d="scan'208";a="266626401" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga006.jf.intel.com with ESMTP; 15 May 2020 08:00:30 -0700 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1jZbpA-006tQd-83; Fri, 15 May 2020 18:00:32 +0300 Date: Fri, 15 May 2020 18:00:32 +0300 From: Andy Shevchenko To: Serge Semin Cc: Serge Semin , Mark Brown , Georgy Vlasov , Ramil Zaripov , Alexey Malahov , Thomas Bogendoerfer , Paul Burton , Ralf Baechle , Allison Randal , Gareth Williams , Arnd Bergmann , Rob Herring , linux-mips@vger.kernel.org, devicetree@vger.kernel.org, Jarkko Nikula , Wan Ahmad Zainie , Thomas Gleixner , Clement Leger , Xinwei Kong , "wuxu.wu" , Phil Edworthy , Linus Walleij , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 08/19] spi: dw: Discard dma_width member of the dw_spi structure Message-ID: <20200515150032.GK1634618@smile.fi.intel.com> References: <20200508132943.9826-1-Sergey.Semin@baikalelectronics.ru> <20200515104758.6934-1-Sergey.Semin@baikalelectronics.ru> <20200515104758.6934-9-Sergey.Semin@baikalelectronics.ru> <20200515130305.GA1634618@smile.fi.intel.com> <20200515130559.psq2zwfhovt6rzhl@mobilestation> <20200515134956.GC1634618@smile.fi.intel.com> <20200515141627.pqdaic6wksatusl6@mobilestation> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200515141627.pqdaic6wksatusl6@mobilestation> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 15, 2020 at 05:16:27PM +0300, Serge Semin wrote: > On Fri, May 15, 2020 at 04:49:56PM +0300, Andy Shevchenko wrote: > > On Fri, May 15, 2020 at 04:05:59PM +0300, Serge Semin wrote: > > > On Fri, May 15, 2020 at 04:03:05PM +0300, Andy Shevchenko wrote: > > > > On Fri, May 15, 2020 at 01:47:47PM +0300, Serge Semin wrote: > > > > > This member has exactly the same value as n_bytes of the DW SPI private > > > > > data object, it's calculated at the same point of the transfer method, > > > > > n_bytes isn't changed during the whole transfer, and they even serve for > > > > > the same purpose - keep number of bytes per transfer word, though the > > > > > dma_width is used only to calculate the DMA source/destination addresses > > > > > width, which n_bytes could be also utilized for. Taking all of these > > > > > into account let's replace the dma_width member usage with n_bytes one > > > > > and remove the former. > > > > > > > > I've no strong opinion about this. > > > > So, after addressing one issue below, > > > > Reviewed-by: Andy Shevchenko > > > > ... > > > > > > > -static enum dma_slave_buswidth convert_dma_width(u32 dma_width) { > > > > > - if (dma_width == 1) > > > > > > > > > +static enum dma_slave_buswidth convert_dma_width(u8 n_bytes) { > > > > > > > > It seems somebody (maybe even me) at some point messed up between enum > > > > definition and function that returns an enum. > > > > > > > > For what said, { should be on the separate line. > > > > > > See the patch 16/19: "spi: dw: Cleanup generic DW DMA code namings" > > > in this series. > > > > Since you are touching that line here, it makes sense to do it here rather than > > ping-pong to other patch in very same series. > > You didn't open the patch I referred to, did you? Patches in the series are going on purpose. I look at them in the sequence of the appearance. But okay, I looked at it and I found what I expected. I think that you may reorder patch 16 to be one right after renaming module. > If you did, you would have > seen that I touched that line there too in the framework of the naming cleanup > procedure. So please, stop wasting my time with trivial stuff. Haven't you missed my tag? It means I spent *my* time on *your* stuff. Please, be respectful to reviewers. -- With Best Regards, Andy Shevchenko