From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DC99C433DF for ; Fri, 15 May 2020 15:04:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 642BB207C4 for ; Fri, 15 May 2020 15:04:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727819AbgEOPEY (ORCPT ); Fri, 15 May 2020 11:04:24 -0400 Received: from mga18.intel.com ([134.134.136.126]:15625 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726171AbgEOPDz (ORCPT ); Fri, 15 May 2020 11:03:55 -0400 IronPort-SDR: gSJMJU+NZAQr9DsqTBBq2wIOWQLfq3BxecP9zfEBRNuxHTX0FIow1j6r8d8UgqkcXAEa2bzuNK TXv6zZj+5XaQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2020 08:03:54 -0700 IronPort-SDR: oeebT3F+ujbIeM9EWX7T/No0xt0Pr8AR5msV70GdGtgm5+5lr2eznhAaLNmS9kKoJGwA4lmXlK ZkzISOFVMs1Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,395,1583222400"; d="scan'208";a="281243099" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga002.jf.intel.com with ESMTP; 15 May 2020 08:03:49 -0700 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1jZbsN-006tSa-HL; Fri, 15 May 2020 18:03:51 +0300 Date: Fri, 15 May 2020 18:03:51 +0300 From: Andy Shevchenko To: Serge Semin Cc: Mark Brown , Serge Semin , Georgy Vlasov , Ramil Zaripov , Alexey Malahov , Thomas Bogendoerfer , Paul Burton , Ralf Baechle , Arnd Bergmann , Allison Randal , Gareth Williams , Rob Herring , linux-mips@vger.kernel.org, devicetree@vger.kernel.org, John Garry , Chuanhong Guo , Masahisa Kojima , Chris Packham , Tomer Maimon , Krzysztof Kozlowski , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 15/19] spi: dw: Add DW SPI DMA/PCI/MMIO dependency on the DW SPI core Message-ID: <20200515150351.GM1634618@smile.fi.intel.com> References: <20200508132943.9826-1-Sergey.Semin@baikalelectronics.ru> <20200515104758.6934-1-Sergey.Semin@baikalelectronics.ru> <20200515104758.6934-16-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200515104758.6934-16-Sergey.Semin@baikalelectronics.ru> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 15, 2020 at 01:47:54PM +0300, Serge Semin wrote: > Seeing all of the DW SPI driver components like DW SPI DMA/PCI/MMIO > depend on the DW SPI core code it's better to use the if-endif > conditional kernel config statement to signify that common dependency. Makes sense! Reviewed-by: Andy Shevchenko > > Co-developed-by: Georgy Vlasov > Signed-off-by: Georgy Vlasov > Co-developed-by: Ramil Zaripov > Signed-off-by: Ramil Zaripov > Signed-off-by: Serge Semin > Cc: Alexey Malahov > Cc: Thomas Bogendoerfer > Cc: Paul Burton > Cc: Ralf Baechle > Cc: Arnd Bergmann > Cc: Allison Randal > Cc: Andy Shevchenko > Cc: Gareth Williams > Cc: Rob Herring > Cc: linux-mips@vger.kernel.org > Cc: devicetree@vger.kernel.org > --- > drivers/spi/Kconfig | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig > index 6a84f3dad35c..3cdf8310d185 100644 > --- a/drivers/spi/Kconfig > +++ b/drivers/spi/Kconfig > @@ -226,17 +226,20 @@ config SPI_DESIGNWARE > help > general driver for SPI controller core from DesignWare > > +if SPI_DESIGNWARE > + > config SPI_DW_DMA > bool "DMA support for DW SPI controller" > - depends on SPI_DESIGNWARE > > config SPI_DW_PCI > tristate "PCI interface driver for DW SPI core" > - depends on SPI_DESIGNWARE && PCI > + depends on PCI > > config SPI_DW_MMIO > tristate "Memory-mapped io interface driver for DW SPI core" > - depends on SPI_DESIGNWARE > + depends on HAS_IOMEM > + > +endif > > config SPI_DLN2 > tristate "Diolan DLN-2 USB SPI adapter" > -- > 2.25.1 > -- With Best Regards, Andy Shevchenko