From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5328EC433E0 for ; Fri, 15 May 2020 15:10:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2379F2076A for ; Fri, 15 May 2020 15:10:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589555443; bh=D6LeDgR+1gAiJOELm9U6DKJLT5pJy4kJssGSOYAl/ZU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=m8u0QB7qgg3/pLyBqCDnMWzYnsqnHYecB7a8EPnMbYz5YyRbsO9D+hm8J5PrloVtU oFi8Ky5kwMGSF+0Y2bsDZ7EHHFSpAyA0RJPrOZk6iaKoGAkz5+SZD1J+2C3La/m2LU OHi/5/sR/8YeidyJErrT+ZItp+67H6l1rc/QngGE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728289AbgEOPKm (ORCPT ); Fri, 15 May 2020 11:10:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:49870 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728277AbgEOPKj (ORCPT ); Fri, 15 May 2020 11:10:39 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CF73D2076A; Fri, 15 May 2020 15:10:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589555438; bh=D6LeDgR+1gAiJOELm9U6DKJLT5pJy4kJssGSOYAl/ZU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OrdCAO3haSRFPg/DselJskuyxT7YzART3RxKIHm9SZTu8m+rNgkkeWRnN7Y2vA1vZ my9m9UpCM70NcvXYmC9TZtBCgwdsB+zPrSMxJLk6AvQCAzYOrMM78PmE8SnqxWdnzY OkejeiCks5W/3NKDWg7DVRk36zecA5zBXvum5grs= Date: Fri, 15 May 2020 17:10:36 +0200 From: Greg Kroah-Hartman To: Heikki Krogerus Cc: Randy Dunlap , Brendan Higgins , Linux Kernel Mailing List , Naresh Kamboju , kernel test robot , "Rafael J. Wysocki" Subject: Re: [PATCH] kobject: Make sure the parent does not get released before its children Message-ID: <20200515151036.GA2574646@kroah.com> References: <20200513151840.36400-1-heikki.krogerus@linux.intel.com> <20200514065415.GA1511@kuha.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200514065415.GA1511@kuha.fi.intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 14, 2020 at 09:54:15AM +0300, Heikki Krogerus wrote: > On Wed, May 13, 2020 at 04:14:51PM -0700, Randy Dunlap wrote: > > On 5/13/20 2:30 PM, Brendan Higgins wrote: > > > On Wed, May 13, 2020 at 8:18 AM Heikki Krogerus > > > wrote: > > >> > > >> In the function kobject_cleanup(), kobject_del(kobj) is > > >> called before the kobj->release(). That makes it possible to > > >> release the parent of the kobject before the kobject itself. > > >> > > >> To fix that, adding function __kboject_del() that does > > >> everything that kobject_del() does except release the parent > > >> reference. kobject_cleanup() then calls __kobject_del() > > >> instead of kobject_del(), and separately decrements the > > >> reference count of the parent kobject after kobj->release() > > >> has been called. > > >> > > >> Reported-by: Naresh Kamboju > > >> Reported-by: kernel test robot > > >> Fixes: 7589238a8cf3 ("Revert "software node: Simplify software_node_release() function"") > > >> Cc: Brendan Higgins > > >> Cc: Randy Dunlap > > >> Suggested-by: "Rafael J. Wysocki" > > >> Signed-off-by: Heikki Krogerus > > > > > > Reviewed-by: Brendan Higgins > > > Tested-by: Brendan Higgins > > > > > > > Acked-by: Randy Dunlap > > Tested-by: Randy Dunlap > > Thanks guys. Sorry about the mix-up. I didn't get the chance to review this today, will do so on Monday, thanks. greg k-h