From: Rikard Falkeborn <rikard.falkeborn@gmail.com>
To: kishon@ti.com, vkoul@kernel.org, alcooperx@gmail.com
Cc: linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
Rikard Falkeborn <rikard.falkeborn@gmail.com>
Subject: [PATCH 1/3] phy: phy-bcm-ns2-usbdrd: Constify phy_ops
Date: Sat, 16 May 2020 14:04:39 +0200 [thread overview]
Message-ID: <20200516120441.7627-2-rikard.falkeborn@gmail.com> (raw)
In-Reply-To: <20200516120441.7627-1-rikard.falkeborn@gmail.com>
phy_ops are never modified and can therefore be made const to allow the
compiler to put it in read-only memory.
Before:
text data bss dec hex filename
7831 3144 128 11103 2b5f drivers/phy/broadcom/phy-bcm-ns2-usbdrd.o
After:
text data bss dec hex filename
7959 3016 128 11103 2b5f drivers/phy/broadcom/phy-bcm-ns2-usbdrd.o
Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
---
drivers/phy/broadcom/phy-bcm-ns2-usbdrd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/broadcom/phy-bcm-ns2-usbdrd.c b/drivers/phy/broadcom/phy-bcm-ns2-usbdrd.c
index 7ceea5ae2704..527625912b78 100644
--- a/drivers/phy/broadcom/phy-bcm-ns2-usbdrd.c
+++ b/drivers/phy/broadcom/phy-bcm-ns2-usbdrd.c
@@ -279,7 +279,7 @@ static irqreturn_t gpio_irq_handler(int irq, void *dev_id)
return IRQ_HANDLED;
}
-static struct phy_ops ops = {
+static const struct phy_ops ops = {
.init = ns2_drd_phy_init,
.power_on = ns2_drd_phy_poweron,
.power_off = ns2_drd_phy_poweroff,
--
2.26.2
next prev parent reply other threads:[~2020-05-16 12:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-16 12:04 [PATCH 0/3] phy: broadcom: Constify structs Rikard Falkeborn
2020-05-16 12:04 ` Rikard Falkeborn [this message]
2020-05-16 12:04 ` [PATCH 2/3] phy: sr-usb: Constify phy_ops Rikard Falkeborn
2020-05-16 12:04 ` [PATCH 3/3] phy: phy-brcm-usb: Constify static structs Rikard Falkeborn
2020-05-18 12:14 ` [PATCH 0/3] phy: broadcom: Constify structs Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200516120441.7627-2-rikard.falkeborn@gmail.com \
--to=rikard.falkeborn@gmail.com \
--cc=alcooperx@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).