From: Ira Weiny <ira.weiny@intel.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-ext4@vger.kernel.org,
Andreas Dilger <adilger.kernel@dilger.ca>,
"Theodore Y. Ts'o" <tytso@mit.edu>, Jan Kara <jack@suse.cz>,
Al Viro <viro@zeniv.linux.org.uk>,
Dan Williams <dan.j.williams@intel.com>,
Dave Chinner <david@fromorbit.com>,
Christoph Hellwig <hch@lst.de>, Jeff Moyer <jmoyer@redhat.com>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/9] fs/ext4: Disallow verity if inode is DAX
Date: Sun, 17 May 2020 22:32:07 -0700 [thread overview]
Message-ID: <20200518053207.GB3025231@iweiny-DESK2.sc.intel.com> (raw)
In-Reply-To: <20200516014916.GF1009@sol.localdomain>
On Fri, May 15, 2020 at 06:49:16PM -0700, Eric Biggers wrote:
> On Tue, May 12, 2020 at 10:43:17PM -0700, ira.weiny@intel.com wrote:
> > From: Ira Weiny <ira.weiny@intel.com>
> >
> > Verity and DAX are incompatible. Changing the DAX mode due to a verity
> > flag change is wrong without a corresponding address_space_operations
> > update.
> >
> > Make the 2 options mutually exclusive by returning an error if DAX was
> > set first.
> >
> > (Setting DAX is already disabled if Verity is set first.)
> >
> > Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> >
> > ---
> > Changes:
> > remove WARN_ON_ONCE
> > Add documentation for DAX/Verity exclusivity
> > ---
> > Documentation/filesystems/ext4/verity.rst | 7 +++++++
> > fs/ext4/verity.c | 3 +++
> > 2 files changed, 10 insertions(+)
> >
> > diff --git a/Documentation/filesystems/ext4/verity.rst b/Documentation/filesystems/ext4/verity.rst
> > index 3e4c0ee0e068..51ab1aa17e59 100644
> > --- a/Documentation/filesystems/ext4/verity.rst
> > +++ b/Documentation/filesystems/ext4/verity.rst
> > @@ -39,3 +39,10 @@ is encrypted as well as the data itself.
> >
> > Verity files cannot have blocks allocated past the end of the verity
> > metadata.
> > +
> > +Verity and DAX
> > +--------------
> > +
> > +Verity and DAX are not compatible and attempts to set both of these flags on a
> > +file will fail.
> > +
>
> If you build the documentation, this shows up as its own subsection
> "2.13. Verity and DAX" alongside "2.12. Verity files", which looks odd.
> I think you should delete this new subsection header so that this paragraph goes
> in the existing "Verity files" subsection.
Ok... I'll fix it up...
>
> Also, Documentation/filesystems/fsverity.rst already mentions DAX (similar to
> fscrypt.rst). Is it intentional that you added this to the ext4-specific
> documentation instead?
I proposed this text[1] and there were no objections... I was looking at ext4
because only ext4 supports verity and DAX. I think having this in both the
ext4 docs and the verity docs helps.
Ira
[1] https://lore.kernel.org/lkml/20200415191451.GA2305801@iweiny-DESK2.sc.intel.com/
>
> - Eric
next prev parent reply other threads:[~2020-05-18 5:32 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 5:43 [PATCH 0/9] Enable ext4 support for per-file/directory DAX operations ira.weiny
2020-05-13 5:43 ` [PATCH 1/9] fs/ext4: Narrow scope of DAX check in setflags ira.weiny
2020-05-13 5:43 ` [PATCH 2/9] fs/ext4: Disallow verity if inode is DAX ira.weiny
2020-05-16 1:49 ` Eric Biggers
2020-05-18 5:32 ` Ira Weiny [this message]
2020-05-13 5:43 ` [PATCH 3/9] fs/ext4: Disallow encryption " ira.weiny
2020-05-16 2:02 ` Eric Biggers
2020-05-18 5:03 ` Ira Weiny
2020-05-18 16:24 ` Eric Biggers
2020-05-18 19:23 ` Ira Weiny
2020-05-18 19:44 ` Eric Biggers
2020-05-20 2:02 ` Ira Weiny
2020-05-20 13:11 ` Jan Kara
2020-05-13 5:43 ` [PATCH 4/9] fs/ext4: Change EXT4_MOUNT_DAX to EXT4_MOUNT_DAX_ALWAYS ira.weiny
2020-05-13 11:25 ` Jan Kara
2020-05-13 5:43 ` [PATCH 5/9] fs/ext4: Update ext4_should_use_dax() ira.weiny
2020-05-13 11:30 ` Jan Kara
2020-05-13 5:43 ` [PATCH 6/9] fs/ext4: Only change S_DAX on inode load ira.weiny
2020-05-13 11:33 ` Jan Kara
2020-05-13 5:43 ` [PATCH 7/9] fs/ext4: Make DAX mount option a tri-state ira.weiny
2020-05-13 14:35 ` Jan Kara
2020-05-13 18:17 ` Darrick J. Wong
2020-05-13 19:53 ` Ira Weiny
2020-05-13 5:43 ` [PATCH 8/9] fs/ext4: Introduce DAX inode flag ira.weiny
2020-05-13 14:47 ` Jan Kara
2020-05-13 21:41 ` Ira Weiny
2020-05-14 6:43 ` Jan Kara
2020-05-14 6:55 ` Ira Weiny
2020-05-13 5:43 ` [PATCH 9/9] Documentation/dax: Update DAX enablement for ext4 ira.weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200518053207.GB3025231@iweiny-DESK2.sc.intel.com \
--to=ira.weiny@intel.com \
--cc=adilger.kernel@dilger.ca \
--cc=dan.j.williams@intel.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=ebiggers@kernel.org \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=jmoyer@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).