From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56035C433DF for ; Mon, 18 May 2020 15:00:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3E6202065F for ; Mon, 18 May 2020 15:00:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728097AbgERPAI (ORCPT ); Mon, 18 May 2020 11:00:08 -0400 Received: from mail.baikalelectronics.com ([87.245.175.226]:48704 "EHLO mail.baikalelectronics.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726958AbgERPAF (ORCPT ); Mon, 18 May 2020 11:00:05 -0400 Received: from localhost (unknown [127.0.0.1]) by mail.baikalelectronics.ru (Postfix) with ESMTP id B6998803080B; Mon, 18 May 2020 15:00:00 +0000 (UTC) X-Virus-Scanned: amavisd-new at baikalelectronics.ru Received: from mail.baikalelectronics.ru ([127.0.0.1]) by localhost (mail.baikalelectronics.ru [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IRxMeP9Dze5J; Mon, 18 May 2020 18:00:00 +0300 (MSK) Date: Mon, 18 May 2020 17:59:58 +0300 From: Serge Semin To: Andy Shevchenko CC: Serge Semin , Mark Brown , Alexey Malahov , Thomas Bogendoerfer , Paul Burton , Ralf Baechle , Arnd Bergmann , Allison Randal , Gareth Williams , Rob Herring , , devicetree , Georgy Vlasov , Ramil Zaripov , Jarkko Nikula , Thomas Gleixner , Wan Ahmad Zainie , Linus Walleij , Clement Leger , linux-spi , Linux Kernel Mailing List Subject: Re: [PATCH v2 10/19] spi: dw: Use DMA max burst to set the request thresholds Message-ID: <20200518145958.gb55qtrc6gdpq2d4@mobilestation> References: <20200508132943.9826-1-Sergey.Semin@baikalelectronics.ru> <20200515104758.6934-1-Sergey.Semin@baikalelectronics.ru> <20200515104758.6934-11-Sergey.Semin@baikalelectronics.ru> <20200515143842.GG1634618@smile.fi.intel.com> <20200516200133.wmaqnfjbr7234fzo@mobilestation> <20200518110343.GY1634618@smile.fi.intel.com> <20200518125253.r4fpr4mjflclqpym@mobilestation> <20200518134306.7rvydoasv7pmxwxl@mobilestation> <20200518144834.GD1634618@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20200518144834.GD1634618@smile.fi.intel.com> X-ClientProxiedBy: MAIL.baikal.int (192.168.51.25) To mail (192.168.51.25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 18, 2020 at 05:48:34PM +0300, Andy Shevchenko wrote: > On Mon, May 18, 2020 at 04:43:06PM +0300, Serge Semin wrote: > > On Mon, May 18, 2020 at 04:25:20PM +0300, Andy Shevchenko wrote: > > > On Mon, May 18, 2020 at 3:53 PM Serge Semin > > > wrote: > > > > On Mon, May 18, 2020 at 02:03:43PM +0300, Andy Shevchenko wrote: > > > > > On Sat, May 16, 2020 at 11:01:33PM +0300, Serge Semin wrote: > > > > > > On Fri, May 15, 2020 at 05:38:42PM +0300, Andy Shevchenko wrote: > > > > > > > On Fri, May 15, 2020 at 01:47:49PM +0300, Serge Semin wrote: > > ... > > > > > > > It's not like anyone cared about padding in this structure in the first place) > > > > > > > > > > I think I have been caring (to some extend). > > > > > > > > Well, If you have then instead of asking to rearrange just two members (which > > > > by the way finely grouped by the Tx-Rx affiliation) why not sending a > > > > patch, which would refactor the whole structure so to be optimal for the x64 > > > > platforms? I don't really see why this gets very important for you seeing > > > > Mark is Ok with this. My current commit follows the common driver design > > > > including the DW SSI data members grouping. On the second thought I'll leave > > > > it as is then. > > > > > > Again same issue here. What is really easy to do for you here, will > > > become a burden and additional churn to anybody else. > > > So, why not to minimize it in the first place? Same with comma in > > > another patch. Sorry, I really don't get it. > > > > If comma is more or less understandable (though adding it is absolutely > > redundant there and doesn't worth even a bit of time spending for the > > discussion), here you consider the patch from padding point of view. > > The driver developer didn't care about it, but did care about grouping the > > members in a corresponding way. The padding burden will be there anyway and > > should be fixed for the whole structure in an additional patch. Until then > > the way of grouping should be preserved. > > Like you said, we spent already much more time than that simple change can be > satisfied. And like you said, "deleloper ... did care about groupping members > in a corresponding way". So, if we look at this in the original code, my > suggestion, besides padding benefit, is consistent with existing pattern in > that data structure. What pattern do you mean? As I see it, my implementation is consistent with current structure structure, while yours is not. -Sergey > > Note, I agree on extern keyword change can be postponed (it was in the original > code), but here you introduce a new code... > > -- > With Best Regards, > Andy Shevchenko > >