From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DE50C433DF for ; Mon, 18 May 2020 17:09:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1518020709 for ; Mon, 18 May 2020 17:09:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589821782; bh=n3Jpm9TY854YSFMuLHwI+o4mk5x9P1AZ1cqMTatvLiQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=ChJxhAFVCBxol1MZs4ldpbi6Kuzw3g7tS3NQys6jos2cYohLj8j9LIpY7dkzRmj8K OJsiDXUrYcQIV8K3AgwN2TueZtlsi0OTqJcYAeRdSfrWj/5qm+YfG/bSasxdVyKRZZ 68GCTl/7ZkKlAoWMY8ZFN+Nx+vCfLo2jNsHfbsuc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728436AbgERRJl (ORCPT ); Mon, 18 May 2020 13:09:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:49896 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727006AbgERRJj (ORCPT ); Mon, 18 May 2020 13:09:39 -0400 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 09D96207E8; Mon, 18 May 2020 17:09:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589821779; bh=n3Jpm9TY854YSFMuLHwI+o4mk5x9P1AZ1cqMTatvLiQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=V8L67bWuzL7d4qlbk48Otx7KYfhX0YF5j+C/FGzKYy7zntJaLwj/00MxWZCRYu2aR XIPzulnbJQY2ZCLWNImokFU8DgFzTt/RrzaMWPM28+kKmeRqyQ7uUlq5ynve8p7Hxt jU5kYqCUHm6B0xu6x5HEnbPzhPAVedwMsH5HctNs= Date: Mon, 18 May 2020 18:09:34 +0100 From: Will Deacon To: Anshuman Khandual Cc: mark.rutland@arm.com, Catalin Marinas , linux-kernel@vger.kernel.org, James Morse , Marc Zyngier , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH V2] arm64/cpufeature: Drop open encodings while extracting parange Message-ID: <20200518170934.GT32394@willie-the-truck> References: <1589360614-1164-1-git-send-email-anshuman.khandual@arm.com> <20200518165958.GS32394@willie-the-truck> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200518165958.GS32394@willie-the-truck> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 18, 2020 at 05:59:59PM +0100, Will Deacon wrote: > On Wed, May 13, 2020 at 02:33:34PM +0530, Anshuman Khandual wrote: > > Currently there are multiple instances of parange feature width mask open > > encodings while fetching it's value. Even the width mask value (0x7) itself > > is not accurate. It should be (0xf) per ID_AA64MMFR0_EL1.PARange[3:0] as in > > ARM ARM (0487F.a). Replace them with cpuid_feature_extract_unsigned_field() > > which can extract given standard feature (4 bits width i.e 0xf mask) field. > > > > Cc: Catalin Marinas > > Cc: Will Deacon > > Cc: Marc Zyngier > > Cc: James Morse > > Cc: kvmarm@lists.cs.columbia.edu > > Cc: linux-arm-kernel@lists.infradead.org > > Cc: linux-kernel@vger.kernel.org > > > > Signed-off-by: Anshuman Khandual > > --- > > Changes in V2: > > > > - Used cpuid_feature_extract_unsigned_field() per Mark > > > > Changes in V1: (https://patchwork.kernel.org/patch/11541913/) > > > > arch/arm64/kernel/cpufeature.c | 3 ++- > > arch/arm64/kvm/reset.c | 11 ++++++++--- > > 2 files changed, 10 insertions(+), 4 deletions(-) > > Acked-by: Will Deacon > > I'm assuming Marc will take this, but let me know if it should go via arm64 > instead (where we have a bunch of other cpufeature stuff queued). Hmm, but having just spotted [1], it looks like we might need a bit of co-ordination here. Marc? Will [1] https://lore.kernel.org/r/1589248647-22925-1-git-send-email-anshuman.khandual@arm.com