From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58215C433E0 for ; Mon, 18 May 2020 18:24:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 39E9020657 for ; Mon, 18 May 2020 18:24:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589826248; bh=tbPH4fX5iPahAc68h/Ix2JabO6ya2WIuRe6PLDpthWM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=NpbWt8qMrous1cRyU9LuUBs8JSfCfEImNJr6Tfq94dCRUIRU5fC03aTWHVP5EV4Cv 0X8fx8M6HtGSYEjfOCKt/cztb021Tn8g5dITPBxF1wC3AI59UE0PZ61ff3XG6z41e1 3M4zUnSl+yHrSiOiCsP4sRCtWfhxcZ4EhGYKuAsw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732258AbgERSYH (ORCPT ); Mon, 18 May 2020 14:24:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:49422 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728840AbgERRsa (ORCPT ); Mon, 18 May 2020 13:48:30 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7058C20657; Mon, 18 May 2020 17:48:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589824109; bh=tbPH4fX5iPahAc68h/Ix2JabO6ya2WIuRe6PLDpthWM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ynvYOzKxop+tjqCFPs1FGvfcDJS4gZKEocjxrYFTpyBqhhgB2/B9oUViYgJSjXasx V8yH76ZSdNXNLoy94hT3UYewQhg7WD+6DapEUPUoN4UAZOtZX7jVm+PQ8HkL+kksyl JjtG7iDOvRtYST+yesO0SFKIFZw81u0W4GicCAwU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Ming Lei , Bob Liu , "Steven Rostedt (VMware)" , Cengiz Can , Jens Axboe , Ben Hutchings Subject: [PATCH 4.14 042/114] blktrace: fix dereference after null check Date: Mon, 18 May 2020 19:36:14 +0200 Message-Id: <20200518173511.050085773@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200518173503.033975649@linuxfoundation.org> References: <20200518173503.033975649@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Cengiz Can commit 153031a301bb07194e9c37466cfce8eacb977621 upstream. There was a recent change in blktrace.c that added a RCU protection to `q->blk_trace` in order to fix a use-after-free issue during access. However the change missed an edge case that can lead to dereferencing of `bt` pointer even when it's NULL: Coverity static analyzer marked this as a FORWARD_NULL issue with CID 1460458. ``` /kernel/trace/blktrace.c: 1904 in sysfs_blk_trace_attr_store() 1898 ret = 0; 1899 if (bt == NULL) 1900 ret = blk_trace_setup_queue(q, bdev); 1901 1902 if (ret == 0) { 1903 if (attr == &dev_attr_act_mask) >>> CID 1460458: Null pointer dereferences (FORWARD_NULL) >>> Dereferencing null pointer "bt". 1904 bt->act_mask = value; 1905 else if (attr == &dev_attr_pid) 1906 bt->pid = value; 1907 else if (attr == &dev_attr_start_lba) 1908 bt->start_lba = value; 1909 else if (attr == &dev_attr_end_lba) ``` Added a reassignment with RCU annotation to fix the issue. Fixes: c780e86dd48 ("blktrace: Protect q->blk_trace with RCU") Reviewed-by: Ming Lei Reviewed-by: Bob Liu Reviewed-by: Steven Rostedt (VMware) Signed-off-by: Cengiz Can Signed-off-by: Jens Axboe Signed-off-by: Ben Hutchings Signed-off-by: Greg Kroah-Hartman --- kernel/trace/blktrace.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) --- a/kernel/trace/blktrace.c +++ b/kernel/trace/blktrace.c @@ -1911,8 +1911,11 @@ static ssize_t sysfs_blk_trace_attr_stor } ret = 0; - if (bt == NULL) + if (bt == NULL) { ret = blk_trace_setup_queue(q, bdev); + bt = rcu_dereference_protected(q->blk_trace, + lockdep_is_held(&q->blk_trace_mutex)); + } if (ret == 0) { if (attr == &dev_attr_act_mask)