Re: [RFC][PATCH 1/5] objtool: Exit successfully when requesting help

From: Matt Helsley <mhelsley@vmware.com>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Julien Thierry <jthierry@redhat.com>,
	Miroslav Benes <mbenes@suse.cz>,
	Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [RFC][PATCH 1/5] objtool: Exit successfully when requesting help
Date: Mon, 18 May 2020 11:33:34 -0700	[thread overview]
Message-ID: <20200518183334.GN9040@rlwimi.vmware.com> (raw)
In-Reply-To: <20200515195253.c5yzjyigxzhjflsd@treble>

On Fri, May 15, 2020 at 02:52:53PM -0500, Josh Poimboeuf wrote:
> On Mon, May 11, 2020 at 10:35:09AM -0700, Matt Helsley wrote:
> > When the user requests help it's not an error so do not exit with
> > a non-zero exit code. This is not especially useful for a user but
> > any script that might wish to check that objtool --help is at least
> > available can't rely on the exit code to crudely check that, for
> > example building an objtool executable succeeds.
> > 
> > Signed-off-by: Matt Helsley <mhelsley@vmware.com>
> > ---
> >  tools/objtool/objtool.c | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/tools/objtool/objtool.c b/tools/objtool/objtool.c
> > index 0b3528f05053..593ec85915a9 100644
> > --- a/tools/objtool/objtool.c
> > +++ b/tools/objtool/objtool.c
> > @@ -58,7 +58,10 @@ static void cmd_usage(void)
> >  
> >  	printf("\n");
> >  
> > -	exit(129);
> > +	if (!help)
> > +		exit(129);
> > +	else
> > +		exit(0);
> 
> Looks fine, though the 'else' isn't needed.

OK, removed the 'else'.

Cheers,
    -Matt Helsley