From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C79DC433E0 for ; Mon, 18 May 2020 19:50:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0BF8520657 for ; Mon, 18 May 2020 19:50:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728515AbgERTur (ORCPT ); Mon, 18 May 2020 15:50:47 -0400 Received: from ex13-edg-ou-001.vmware.com ([208.91.0.189]:51977 "EHLO EX13-EDG-OU-001.vmware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727817AbgERTuq (ORCPT ); Mon, 18 May 2020 15:50:46 -0400 Received: from sc9-mailhost3.vmware.com (10.113.161.73) by EX13-EDG-OU-001.vmware.com (10.113.208.155) with Microsoft SMTP Server id 15.0.1156.6; Mon, 18 May 2020 12:50:44 -0700 Received: from localhost (unknown [10.200.192.41]) by sc9-mailhost3.vmware.com (Postfix) with ESMTP id BDFAF40BA4; Mon, 18 May 2020 12:50:45 -0700 (PDT) Date: Mon, 18 May 2020 12:50:45 -0700 From: Matt Helsley To: Josh Poimboeuf CC: , Peter Zijlstra , Julien Thierry , Miroslav Benes , Steven Rostedt Subject: Re: [RFC][PATCH 4/5] objtool: Enable compilation of objtool for all architectures Message-ID: <20200518195045.GQ9040@rlwimi.vmware.com> Mail-Followup-To: Matt Helsley , Josh Poimboeuf , linux-kernel@vger.kernel.org, Peter Zijlstra , Julien Thierry , Miroslav Benes , Steven Rostedt References: <9f709ea2ae66cc03b3ff3329baa8f670ccd0e368.1588888003.git.mhelsley@vmware.com> <20200515205610.fmdimt7wbafypuqc@treble> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20200515205610.fmdimt7wbafypuqc@treble> Received-SPF: None (EX13-EDG-OU-001.vmware.com: mhelsley@vmware.com does not designate permitted sender hosts) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 15, 2020 at 03:56:10PM -0500, Josh Poimboeuf wrote: > On Mon, May 11, 2020 at 10:35:12AM -0700, Matt Helsley wrote: > > +struct insn_state { > > + struct cfi_reg cfa; > > + struct cfi_reg regs[CFI_NUM_REGS]; > > + int stack_size; > > + unsigned char type; > > + bool bp_scratch; > > + bool drap, end, uaccess, df; > > + bool noinstr; > > + s8 instr; > > + unsigned int uaccess_stack; > > + int drap_reg, drap_offset; > > + struct cfi_reg vals[CFI_NUM_REGS]; > > +}; > > + > > +struct instruction { > > + struct list_head list; > > + struct hlist_node hash; > > + struct section *sec; > > + unsigned long offset; > > + unsigned int len; > > + enum insn_type type; > > + unsigned long immediate; > > + bool alt_group, dead_end, ignore, hint, save, restore, ignore_alts; > > + bool retpoline_safe; > > + s8 instr; > > + u8 visited; > > + struct symbol *call_dest; > > + struct instruction *jump_dest; > > + struct instruction *first_jump_src; > > + struct rela *jump_table; > > + struct list_head alts; > > + struct symbol *func; > > + struct stack_op stack_op; > > + struct insn_state state; > > + struct orc_entry orc; > > +}; > > Why were these moved to arch.h? They're not necessarily arch-specific, > but rather "check"-specific, so I think they still belong in check.h, if > possible. Ah, found it. They are arch specific due to struct orc_entry, which is presently not defined for any archs besides x86. Prior to the patch (-> means "includes"): check.h -> asm/orc_types.h (defines struct orc_entry) orc_gen.c -> check,h After patch: check.c -> asm/orc_types.h orc_gen.c -> asm/orc_types.h orc_gen.c -> check.h orc_gen.c -> arch.h { now weak.c } -> check.h So this prevents the headers, which help us keep the weak definitions consistent with the strong definitions, from breaking compiles on archs that lack struct orc_entry. I'm not sure what the best way to remove this dependency is without a nasty void * for the orc entry, or some #ifdef games related to checking for cpp defines from asm/orc_types.h. This approach neatly avoids conditional preprocessor games and type casting though I do agree it's surprising. Do you have any advice here? Cheers, -Matt Helsley