* linux-next: Signed-off-by missing for commit in the wireless-drivers-next tree
@ 2020-05-18 13:03 Stephen Rothwell
2020-05-19 8:52 ` Kalle Valo
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2020-05-18 13:03 UTC (permalink / raw)
To: Kalle Valo, Wireless
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Felix Fietkau
[-- Attachment #1: Type: text/plain, Size: 219 bytes --]
Hi all,
Commits
89829c9e65ab ("mt76: mt7663: fix DMA unmap length")
c0f8055b3986 ("mt76: mt7622: fix DMA unmap length")
are missing a Signed-off-by from their committer.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: Signed-off-by missing for commit in the wireless-drivers-next tree
2020-05-18 13:03 linux-next: Signed-off-by missing for commit in the wireless-drivers-next tree Stephen Rothwell
@ 2020-05-19 8:52 ` Kalle Valo
0 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2020-05-19 8:52 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Wireless, Linux Next Mailing List, Linux Kernel Mailing List,
Felix Fietkau
Stephen Rothwell <sfr@canb.auug.org.au> writes:
> Commits
>
> 89829c9e65ab ("mt76: mt7663: fix DMA unmap length")
> c0f8055b3986 ("mt76: mt7622: fix DMA unmap length")
>
> are missing a Signed-off-by from their committer.
Darn, missed that. It's quite difficult to fix this one (there's a
signed tag etc) so I'll leave it be. But I definitely need to add some
automatic checking also for s-o-b.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: Signed-off-by missing for commit in the wireless-drivers-next tree
2019-02-10 20:28 Stephen Rothwell
@ 2019-02-11 6:12 ` Kalle Valo
0 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2019-02-11 6:12 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Wireless, Linux Next Mailing List, Linux Kernel Mailing List,
Govind Singh, ath10k
+ ath10k
Stephen Rothwell <sfr@canb.auug.org.au> writes:
> Hi all,
>
> Commit
>
> 768ec4c012ac ("ath10k: update HOST capability qmi message")
>
> is missing a Signed-off-by from its author.
Oh, I had missed that. Thanks for reporting.
Unfortunately it would be difficult to rebase wireless-drivers-next so I
can't (easily) fix this. But v1 had s-o-b so at least we have the sign
off publically available:
https://patchwork.kernel.org/patch/10688563/
--
Kalle Valo
^ permalink raw reply [flat|nested] 6+ messages in thread
* linux-next: Signed-off-by missing for commit in the wireless-drivers-next tree
@ 2019-02-10 20:28 Stephen Rothwell
2019-02-11 6:12 ` Kalle Valo
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2019-02-10 20:28 UTC (permalink / raw)
To: Kalle Valo, Wireless
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Govind Singh
[-- Attachment #1: Type: text/plain, Size: 165 bytes --]
Hi all,
Commit
768ec4c012ac ("ath10k: update HOST capability qmi message")
is missing a Signed-off-by from its author.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: Signed-off-by missing for commit in the wireless-drivers-next tree
2018-04-25 0:56 Stephen Rothwell
@ 2018-04-25 5:31 ` Luciano Coelho
0 siblings, 0 replies; 6+ messages in thread
From: Luciano Coelho @ 2018-04-25 5:31 UTC (permalink / raw)
To: Stephen Rothwell, Kalle Valo, Wireless
Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
Gregory Greenman, Sara Sharon
Hi,
On Wed, 2018-04-25 at 10:56 +1000, Stephen Rothwell wrote:
> Hi all,
>
> Commit
>
> 84226ca1c5d3 ("iwlwifi: mvm: support offload of AMSDU rate
> control")
>
> is missing a Signed-off-by from its author.
I checked this and it should be fine. The author is actually wrong in
the commit. Sara is the actual author and we have her S-o-B in the
commit.
I have no idea how Gregory became the author in that commit, though. I
checked exactly how I committed it and checked the author in our
internal tree. It's all fine, but for some really weird reason that I
can't figure out, Gregory became the author of the commit when I
applied that patch. The AuthorDate is also wrong. I checked my bash
history to see how I applied the patch and everything looks normal...
*confused*
--
Cheers,
Luca.
^ permalink raw reply [flat|nested] 6+ messages in thread
* linux-next: Signed-off-by missing for commit in the wireless-drivers-next tree
@ 2018-04-25 0:56 Stephen Rothwell
2018-04-25 5:31 ` Luciano Coelho
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2018-04-25 0:56 UTC (permalink / raw)
To: Kalle Valo, Wireless
Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
Gregory Greenman, Sara Sharon, Luca Coelho
[-- Attachment #1: Type: text/plain, Size: 174 bytes --]
Hi all,
Commit
84226ca1c5d3 ("iwlwifi: mvm: support offload of AMSDU rate control")
is missing a Signed-off-by from its author.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-05-19 8:52 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-18 13:03 linux-next: Signed-off-by missing for commit in the wireless-drivers-next tree Stephen Rothwell
2020-05-19 8:52 ` Kalle Valo
-- strict thread matches above, loose matches on Subject: below --
2019-02-10 20:28 Stephen Rothwell
2019-02-11 6:12 ` Kalle Valo
2018-04-25 0:56 Stephen Rothwell
2018-04-25 5:31 ` Luciano Coelho
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).