From: David Miller <davem@davemloft.net>
To: jk@ozlabs.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
benh@kernel.crashing.org, paulus@samba.org,
fthain@telegraphics.com.au, userm57@yahoo.com
Subject: Re: [PATCH] net: bmac: Fix read of MAC address from ROM
Date: Tue, 19 May 2020 12:03:51 -0700 (PDT) [thread overview]
Message-ID: <20200519.120351.1307026516427954350.davem@davemloft.net> (raw)
In-Reply-To: <20200519010558.24805-1-jk@ozlabs.org>
From: Jeremy Kerr <jk@ozlabs.org>
Date: Tue, 19 May 2020 09:05:58 +0800
> In bmac_get_station_address, We're reading two bytes at a time from ROM,
> but we do that six times, resulting in 12 bytes of read & writes. This
> means we will write off the end of the six-byte destination buffer.
>
> This change fixes the for-loop to only read/write six bytes.
>
> Based on a proposed fix from Finn Thain <fthain@telegraphics.com.au>.
>
> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
> Reported-by: Stan Johnson <userm57@yahoo.com>
> Tested-by: Stan Johnson <userm57@yahoo.com>
> Reported-by: Finn Thain <fthain@telegraphics.com.au>
Applied, thanks.
prev parent reply other threads:[~2020-05-19 19:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4863b7d34cf23d269921ad133dc585ec83a0bb63.camel@ozlabs.org>
2020-05-19 1:05 ` [PATCH] net: bmac: Fix read of MAC address from ROM Jeremy Kerr
2020-05-19 19:03 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200519.120351.1307026516427954350.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=benh@kernel.crashing.org \
--cc=fthain@telegraphics.com.au \
--cc=jk@ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=userm57@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).