From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B11A5C433E1 for ; Tue, 19 May 2020 09:22:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8CFB5207D8 for ; Tue, 19 May 2020 09:22:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728374AbgESJWN (ORCPT ); Tue, 19 May 2020 05:22:13 -0400 Received: from mga14.intel.com ([192.55.52.115]:39906 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726358AbgESJWM (ORCPT ); Tue, 19 May 2020 05:22:12 -0400 IronPort-SDR: a+Zo8fZcTo/WVeqQdOd9OmpMIERmZq7unbZhy01Od9lGvy0+rhfpKDG5IsPqr41fDybxBSCCTc Lr0niFdadg6w== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2020 02:22:11 -0700 IronPort-SDR: 8j68tHuc1QcJNBPZx5GrAM4yqAJBRFFpuCf4oXE/synt8I1biu4iTX9PLv8aTXqXp5xPWJAWqC APxMp1AlF1Zg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,409,1583222400"; d="scan'208";a="373669435" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga001.fm.intel.com with ESMTP; 19 May 2020 02:22:09 -0700 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1jayRw-007bhX-1i; Tue, 19 May 2020 12:22:12 +0300 Date: Tue, 19 May 2020 12:22:12 +0300 From: Andy Shevchenko To: Jonathan Albrieux Cc: linux-kernel@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Greg Kroah-Hartman , Hartmut Knaack , Jonathan Cameron , Lars-Peter Clausen , Linus Walleij , "open list:IIO SUBSYSTEM AND DRIVERS" , Peter Meerwald-Stadler , Thomas Gleixner Subject: Re: [PATCH v2 0/3] iio: magnetometer: ak8975: Add gpio reset support Message-ID: <20200519092212.GT1634618@smile.fi.intel.com> References: <20200519065749.4624-1-jonathan.albrieux@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200519065749.4624-1-jonathan.albrieux@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 19, 2020 at 08:57:40AM +0200, Jonathan Albrieux wrote: > Convert documentation from txt format to yaml. Add documentation about > reset-gpio. Trailing white space (though it doesn't matter here, in cover letter). > Deassert reset on ak8975_power_on, assert reset on ak8975_power_off. > > Without reset's deassertion during ak8975_power_on, driver's probe fails > on ak8975_who_i_am while checking for device identity for AK09911 chip > > AK09911 has an active low reset gpio to handle register's reset. > AK09911 datasheed says that, if not used, reset pin should be connected > to VID. This patch emulates this situation I dunno if it's your first submission to Linux kernel project or other OSS, but here you missed a changelog. Rule of thumb is to provide a summary of the changes done in the history of the evolution of a patch series. -- With Best Regards, Andy Shevchenko