From: Jonathan Albrieux <jonathan.albrieux@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Linus Walleij <linus.walleij@linaro.org>,
"open list:IIO SUBSYSTEM AND DRIVERS" <linux-iio@vger.kernel.org>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Thomas Gleixner <tglx@linutronix.de>,
Jonathan Cameron <jic23@kernel.org>,
Jilayne Lovejoy <opensource@jilayne.com>
Subject: Re: [PATCH v2 3/3] iio: magnetometer: ak8975: Add gpio reset support
Date: Tue, 19 May 2020 11:44:18 +0200 [thread overview]
Message-ID: <20200519094418.GA10391@ict14-OptiPlex-980> (raw)
In-Reply-To: <20200519092127.GS1634618@smile.fi.intel.com>
On Tue, May 19, 2020 at 12:21:27PM +0300, Andy Shevchenko wrote:
> On Tue, May 19, 2020 at 08:57:43AM +0200, Jonathan Albrieux wrote:
>
> Thanks for an update, my comments below.
>
Thanks to you for taking time to review the code!
> > According to AK09911 datasheet, if reset gpio is provided then
>
> Trailing whitespace.
>
> > deassert reset on ak8975_power_on and assert reset on ak8975_power_off.
> >
> > Without reset's deassertion during ak8975_power_on, driver's probe fails on
> > ak8975_who_i_am while checking for device identity for AK09911 chip
> >
> > AK09911 has an active low reset gpio to handle register's reset.
> > AK09911 datasheed says that, if not used, reset pin should be connected
> > to VID. This patch emulates this situation
>
> Please, put periods at the end of the phrases.
>
> > /*
> > - * According to the datasheet the power supply rise time i 200us
> > + * According to the datasheet the power supply rise time is 200us
> > * and the minimum wait time before mode setting is 100us, in
> > - * total 300 us. Add some margin and say minimum 500us here.
> > + * total 300us. Add some margin and say minimum 500us here.
> > */
>
> This is not related change (perhaps, you may do in separate patch), but I'm not
> against it. Up to maintainer.
>
Ok I will separate the patch
> > + /*
> > + * According to AK09911 datasheet, if reset gpio is provided then
> > + * deassert reset on ak8975_power_on and assert reset on
> > + * ak8975_power_off.
>
> We try to refer to the code accordingly to the kernel doc recommendations (even
> for non-kdoc comments). So, here, 'function' as 'function()' (without quotes)
> and so on.
>
Will fix this as like as the other changes you pointed out about periods and
trailing spaces as soon as possible
> > + */
> > + reset_gpiod = devm_gpiod_get_optional(&client->dev,
> > + "reset", GPIOD_OUT_HIGH);
> > + if (IS_ERR(reset_gpiod))
> > + return PTR_ERR(reset_gpiod);
> > +
> > /* Register with IIO */
> > indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*data));
> > if (indio_dev == NULL)
> > @@ -866,6 +883,7 @@ static int ak8975_probe(struct i2c_client *client,
> >
> > data->client = client;
> > data->eoc_gpiod = eoc_gpiod;
> > + data->reset_gpiod = reset_gpiod;
> > data->eoc_irq = 0;
> >
> > err = iio_read_mount_matrix(&client->dev, "mount-matrix", &data->orientation);
> > --
> > 2.17.1
> >
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
Again, thank you,
Best regards,
Jonathan Albrieux
next prev parent reply other threads:[~2020-05-19 9:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 6:57 [PATCH v2 0/3] iio: magnetometer: ak8975: Add gpio reset support Jonathan Albrieux
2020-05-19 6:57 ` [PATCH v2 1/3] dt-bindings: iio: magnetometer: ak8975: convert txt format to yaml Jonathan Albrieux
2020-05-19 6:57 ` [PATCH v2 2/3] dt-bindings: iio: magnetometer: ak8975: add gpio reset support Jonathan Albrieux
2020-05-19 6:57 ` [PATCH v2 3/3] iio: magnetometer: ak8975: Add " Jonathan Albrieux
2020-05-19 9:21 ` Andy Shevchenko
2020-05-19 9:44 ` Jonathan Albrieux [this message]
2020-05-19 9:22 ` [PATCH v2 0/3] " Andy Shevchenko
2020-05-19 9:48 ` Jonathan Albrieux
2020-05-19 10:08 ` Andy Shevchenko
2020-05-19 10:19 ` Jonathan Albrieux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200519094418.GA10391@ict14-OptiPlex-980 \
--to=jonathan.albrieux@gmail.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=opensource@jilayne.com \
--cc=pmeerw@pmeerw.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).