From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F30FC433E1 for ; Tue, 19 May 2020 18:29:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 33E972075F for ; Tue, 19 May 2020 18:29:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="1XVZ5oVE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729528AbgESS30 (ORCPT ); Tue, 19 May 2020 14:29:26 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:39514 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726161AbgESS3Z (ORCPT ); Tue, 19 May 2020 14:29:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=6uCQIOARttavPA6jMK2O27q7AM5rPupXUJtqotwWi1Q=; b=1XVZ5oVE7XtBh5zBkgH16yxly3 xp6tfNbcdSexEsqB5s7AEL7MkxuYEty1CC6UvPZUUq6Szy9LXuMzbIn55KqlHvn2U5ufQxSaaA3Pf l3hZiuWdZwbempjBz5K+jItnAO5s+IzBS3qxDa+/xnBOtl02rgMMs5TVRzptC6dbvYCY=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1jb6zM-002jfC-Pp; Tue, 19 May 2020 20:29:16 +0200 Date: Tue, 19 May 2020 20:29:16 +0200 From: Andrew Lunn To: Jakub Kicinski Cc: Dan Murphy , f.fainelli@gmail.com, hkallweit1@gmail.com, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH net-next 2/4] net: phy: dp83869: Set opmode from straps Message-ID: <20200519182916.GM624248@lunn.ch> References: <20200519141813.28167-1-dmurphy@ti.com> <20200519141813.28167-3-dmurphy@ti.com> <20200519095818.425d227b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200519095818.425d227b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 19, 2020 at 09:58:18AM -0700, Jakub Kicinski wrote: > On Tue, 19 May 2020 09:18:11 -0500 Dan Murphy wrote: > > If the op-mode for the device is not set in the device tree then set > > the strapped op-mode and store it for later configuration. > > > > Signed-off-by: Dan Murphy > > ../drivers/net/phy/dp83869.c: In function0 dp83869_set_strapped_mode: > ../drivers/net/phy/dp83869.c:171:10: warning: comparison is always false due to limited range of data type [-Wtype-limits] > 171 | if (val < 0) > | ^ Hi Jakub This happens a lot with PHY drivers. The register being read is a u16, so that is what people use. Is this now a standard GCC warning? Or have you turned on extra checking? Andrew