From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03A89C433E0 for ; Tue, 19 May 2020 18:40:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E8F67207D3 for ; Tue, 19 May 2020 18:40:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727046AbgESSke (ORCPT ); Tue, 19 May 2020 14:40:34 -0400 Received: from mga06.intel.com ([134.134.136.31]:60774 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726489AbgESSkd (ORCPT ); Tue, 19 May 2020 14:40:33 -0400 IronPort-SDR: g/GadjegmeKhOlxFuR/BwCDwudzmgy65x9FvY96sLGuS+6iOVyu/hnvgyJt9Sx0JeJbex9DqUj L5g5+NnhDCgA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2020 11:40:33 -0700 IronPort-SDR: D+jm1xpsdiPApGucH8RonxhW2osAHv0gYp6yWvUx7peRxHsoQ0vFEHwV7Czh/gp76Png2rfKJj 4SSgNhc/QOEA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,410,1583222400"; d="scan'208";a="264403264" Received: from iweiny-desk2.sc.intel.com ([10.3.52.147]) by orsmga003.jf.intel.com with ESMTP; 19 May 2020 11:40:32 -0700 Date: Tue, 19 May 2020 11:40:32 -0700 From: Ira Weiny To: Guenter Roeck Cc: linux-kernel@vger.kernel.org, Andrew Morton , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Benjamin Herrenschmidt , Paul Mackerras , "David S. Miller" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Chris Zankel , Max Filippov , Dan Williams , linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org, dri-devel@lists.freedesktop.org, Christian Koenig , Al Viro , Christoph Hellwig Subject: Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice Message-ID: <20200519184031.GB3356843@iweiny-DESK2.sc.intel.com> References: <20200507150004.1423069-8-ira.weiny@intel.com> <20200518184843.3029640-1-ira.weiny@intel.com> <20200519165422.GA5838@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200519165422.GA5838@roeck-us.net> User-Agent: Mutt/1.11.1 (2018-12-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 19, 2020 at 09:54:22AM -0700, Guenter Roeck wrote: > On Mon, May 18, 2020 at 11:48:43AM -0700, ira.weiny@intel.com wrote: > > From: Ira Weiny > > > > The kunmap_atomic clean up failed to remove one set of pagefault/preempt > > enables when vaddr is not in the fixmap. > > > > Fixes: bee2128a09e6 ("arch/kunmap_atomic: consolidate duplicate code") > > Signed-off-by: Ira Weiny > > microblazeel works with this patch, Awesome... Andrew in my rush yesterday I should have put a reported by on the patch for Guenter as well. Sorry about that Guenter, Ira > as do the nosmp sparc32 boot tests, > but sparc32 boot tests with SMP enabled still fail with lots of messages > such as: > > BUG: Bad page state in process swapper/0 pfn:006a1 > page:f0933420 refcount:0 mapcount:1 mapping:(ptrval) index:0x1 > flags: 0x0() > raw: 00000000 00000100 00000122 00000000 00000001 00000000 00000000 00000000 > page dumped because: nonzero mapcount > Modules linked in: > CPU: 0 PID: 1 Comm: swapper/0 Tainted: G B 5.7.0-rc6-next-20200518-00002-gb178d2d56f29 #1 > [f00e7ab8 : > bad_page+0xa8/0x108 ] > [f00e8b54 : > free_pcppages_bulk+0x154/0x52c ] > [f00ea024 : > free_unref_page+0x54/0x6c ] > [f00ed864 : > free_reserved_area+0x58/0xec ] > [f0527104 : > kernel_init+0x14/0x110 ] > [f000b77c : > ret_from_kernel_thread+0xc/0x38 ] > [00000000 : > 0x0 ] > > Code path leading to that message is different but always the same > from free_unref_page(). > > Still testing ppc images. > > Guenter