From: andi@notmuch.email
To: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
Cc: Brendan Shanks <bshanks@codeweavers.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Babu Moger <Babu.Moger@amd.com>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
Jason Yan <yanaijie@huawei.com>,
linux-kernel@vger.kernel.org
Subject: Re: umip: AMD Ryzen 3900X, pagefault after emulate SLDT/SIDT instruction
Date: Wed, 20 May 2020 03:04:18 +0200 [thread overview]
Message-ID: <20200520010418.ippljxawcwrbp6o2@wrt> (raw)
In-Reply-To: <20200519194320.GA25138@ranerica-svr.sc.intel.com>
On 12:43 19.05.20, Ricardo Neri wrote:
> > > Running the same executable on the exact same kernel (and userland) but
> > > on a Intel i7-8565U doesn't crash at this point. I am guessing the
> > > emulation is supposed to do something different on AMD CPUs?
>
> I am surprised you don't see it on the Intel processor. Maybe it does
> not have UMIP. Do you see umip when you do
>
> $ grep umip /proc/cpuinfo
Indeed it doesn't ahve the feature. I would have assumed that it is
recent enough. Apparently not.
> > > On the Ryzen the code executes successfully after setting CONFIG_X86_UMIP=n.
> >
> > Hi Andreas,
> >
> > The problem is that the kernel does not emulate/spoof the SLDT instruction, only SGDT, SIDT, and SMSW.
> > SLDT and STR weren't thought to be commonly used, so emulation/spoofing wasn’t added.
> > In the last few months I have seen reports of one or two (32-bit) Windows games that use SLDT though.
> > Can you share more information about the application you’re running?
> >
> > Maybe the best path is to add kernel emulation/spoofing for SLDT and STR on 32 and 64-bit, just to cover all the cases. It should be a pretty simple patch, I’ll start working on it.
>
> I have a patch for this already that I wrote for testing purposes:
>
> https://github.com/ricardon/tip/commit/1692889cb3f8accb523d44b682458e234b93be50
>
> Perhaps it can be used as a starting point? Not sure what the spoofing
> value should be, though. Perhaps 0?
I am not entirely sure what it should return in the general case. My
assumption is that 0 might work. Maybe making it configurable like with
the other UMIP constants that I saw?
I'll give the patch a shot and try to figure out what the authors of the
code have to say about it.
next prev parent reply other threads:[~2020-05-20 1:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 14:38 umip: AMD Ryzen 3900X, pagefault after emulate SLDT/SIDT instruction Andreas Rammhold
2020-05-19 18:56 ` Brendan Shanks
2020-05-19 19:43 ` Ricardo Neri
2020-05-20 0:54 ` Andy Lutomirski
2020-05-21 0:56 ` Ricardo Neri
2020-05-21 1:16 ` Andy Lutomirski
2020-05-20 1:04 ` andi [this message]
2020-05-23 2:17 ` Andreas Rammhold
2020-05-26 13:33 ` Ricardo Neri
2020-05-28 11:36 ` Andreas Rammhold
2020-05-20 1:08 ` andi
2020-05-23 2:21 ` andi
2020-05-20 0:17 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200520010418.ippljxawcwrbp6o2@wrt \
--to=andi@notmuch.email \
--cc=Babu.Moger@amd.com \
--cc=bp@alien8.de \
--cc=bshanks@codeweavers.com \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=ricardo.neri-calderon@linux.intel.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=tglx@linutronix.de \
--cc=wangkefeng.wang@huawei.com \
--cc=x86@kernel.org \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).