From: Shawn Guo <shawnguo@kernel.org>
To: peng.fan@nxp.com
Cc: s.hauer@pengutronix.de, leonard.crestez@nxp.com,
abel.vesa@nxp.com, aisheng.dong@nxp.com, kernel@pengutronix.de,
festevam@gmail.com, linux-imx@nxp.com, Anson.Huang@nxp.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH V3 00/10] clk: imx: fixes and improve for i.MX8M
Date: Wed, 20 May 2020 09:27:59 +0800 [thread overview]
Message-ID: <20200520012758.GJ11739@dragon> (raw)
In-Reply-To: <1588830979-11586-1-git-send-email-peng.fan@nxp.com>
On Thu, May 07, 2020 at 01:56:09PM +0800, peng.fan@nxp.com wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Patches rebased on for-next
>
> V3:
> Add R-b tag for patch 1-6,10
> Use clk_mux_ops in patch 7, explain more details in commit log
> Boot test on i.MX8MM/N/MQ/P
>
> V2:
> Patch 7, drop wait after write, add one line comment for write twice
>
> V1:
> Patch 1,2 is to fix the lockdep warning reported by Leonard
> Patch 3 is to fix pll mux bit
> Patch 4 is align with other i.MX8M using gate
> Patch 5 is to simplify i.MX8MP clk root using composite
>
> Patch 3~5 is actually https://patchwork.kernel.org/patch/11402761/
> with a minimal change to patch 5 here.
>
> Patch 6 is to use composite core clk for A53 clk root
> Patch 7,8,9 is actually to fix CORE/BUS clk slice issue.
> This issue is triggerred after we update U-Boot to include
> the A53 clk fixes to sources from PLL, not from A53 root clk,
> because of the signoff timing is 1GHz. U-Boot set the A53 root
> mux to 2, sys pll2 500MHz. Kernel will set the A53 root mux to
> 4, sys pll1 800MHz, then gate off sys pll2 500MHz. Then kernel
> will gate off A53 root because clk_ignore_unsed, A53 directly sources
> PLL, so it is ok to gate off A53 root. However when gate off A53
> root clk, system hang, because the original mux sys pll2 500MHz
> gated off with CLK_OPS_PARENT_ENABLE flag.
>
> It is lucky that we not met issue for other core/bus clk slice
> except A53 ROOT core slice. But it is always triggerred after
> U-Boot and Linux both switch to use ARM PLL for A53 core, but
> have different mux settings for A53 root clk slice.
>
> So the three patches is to address this issue.
>
> Patch 10 is make memrepair as critical.
>
> Peng Fan (10):
> arm64: dts: imx8m: assign clocks for A53
> clk: imx8m: drop clk_hw_set_parent for A53
> clk: imx: imx8mp: fix pll mux bit
> clk: imx8mp: Define gates for pll1/2 fixed dividers
> clk: imx8mp: use imx8m_clk_hw_composite_core to simplify code
> clk: imx8m: migrate A53 clk root to use composite core
> clk: imx: add mux ops for i.MX8M composite clk
> clk: imx: add imx8m_clk_hw_composite_bus
> clk: imx: use imx8m_clk_hw_composite_bus for i.MX8M bus clk slice
Applied 1 ~ 9, thanks.
> clk: imx8mp: mark memrepair clock as critical
prev parent reply other threads:[~2020-05-20 1:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 5:56 [PATCH V3 00/10] clk: imx: fixes and improve for i.MX8M peng.fan
2020-05-07 5:56 ` [PATCH V3 01/10] arm64: dts: imx8m: assign clocks for A53 peng.fan
2020-05-07 5:56 ` [PATCH V3 02/10] clk: imx8m: drop clk_hw_set_parent " peng.fan
2020-05-07 5:56 ` [PATCH V3 03/10] clk: imx: imx8mp: fix pll mux bit peng.fan
2020-05-07 5:56 ` [PATCH V3 04/10] clk: imx8mp: Define gates for pll1/2 fixed dividers peng.fan
2020-05-07 5:56 ` [PATCH V3 05/10] clk: imx8mp: use imx8m_clk_hw_composite_core to simplify code peng.fan
2020-05-07 5:56 ` [PATCH V3 06/10] clk: imx8m: migrate A53 clk root to use composite core peng.fan
2020-05-07 5:56 ` [PATCH V3 07/10] clk: imx: add mux ops for i.MX8M composite clk peng.fan
2020-05-07 5:56 ` [PATCH V3 08/10] clk: imx: add imx8m_clk_hw_composite_bus peng.fan
2020-05-07 5:56 ` [PATCH V3 09/10] clk: imx: use imx8m_clk_hw_composite_bus for i.MX8M bus clk slice peng.fan
2020-05-07 5:56 ` [PATCH V3 10/10] clk: imx8mp: mark memrepair clock as critical peng.fan
2020-05-07 6:59 ` Aisheng Dong
2020-05-07 7:59 ` Peng Fan
2020-05-07 6:58 ` [PATCH V3 00/10] clk: imx: fixes and improve for i.MX8M Aisheng Dong
2020-05-20 1:27 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200520012758.GJ11739@dragon \
--to=shawnguo@kernel.org \
--cc=Anson.Huang@nxp.com \
--cc=abel.vesa@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).