From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D124C433E1 for ; Wed, 20 May 2020 04:56:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 62D2F20748 for ; Wed, 20 May 2020 04:56:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726741AbgETE4c (ORCPT ); Wed, 20 May 2020 00:56:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726493AbgETE4b (ORCPT ); Wed, 20 May 2020 00:56:31 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0658BC061A0E for ; Tue, 19 May 2020 21:56:31 -0700 (PDT) Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jbGmI-0006ye-Kw; Wed, 20 May 2020 06:56:26 +0200 Received: from ore by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1jbGmI-0003cM-7L; Wed, 20 May 2020 06:56:26 +0200 Date: Wed, 20 May 2020 06:56:26 +0200 From: Oleksij Rempel To: Andrew Lunn Cc: Michal Kubecek , Marek Vasut , Florian Fainelli , Jonathan Corbet , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Russell King , mkl@pengutronix.de, kernel@pengutronix.de, David Jander , Jakub Kicinski , Christian Herber , "David S. Miller" , Heiner Kallweit Subject: Re: [PATCH net-next v1 1/2] ethtool: provide UAPI for PHY Signal Quality Index (SQI) Message-ID: <20200520045626.hlsthjgxjqsah7zz@pengutronix.de> References: <20200519075200.24631-1-o.rempel@pengutronix.de> <20200519140348.GI624248@lunn.ch> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5qr6a6va65al6rt2" Content-Disposition: inline In-Reply-To: <20200519140348.GI624248@lunn.ch> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 06:55:55 up 186 days, 20:14, 181 users, load average: 0.48, 0.19, 0.07 User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --5qr6a6va65al6rt2 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 19, 2020 at 04:03:48PM +0200, Andrew Lunn wrote: > > --- a/net/ethtool/common.c > > +++ b/net/ethtool/common.c > > @@ -310,6 +310,16 @@ int __ethtool_get_link(struct net_device *dev) > > return netif_running(dev) && dev->ethtool_ops->get_link(dev); > > } > > =20 > > +int __ethtool_get_sqi(struct net_device *dev) > > +{ > > + struct phy_device *phydev =3D dev->phydev; > > + > > + if (!phydev->drv->get_sqi) > > + return -EOPNOTSUPP; > > + > > + return phydev->drv->get_sqi(phydev); > > +} > > + >=20 > You are only providing access via netlink ethtool? There is no ioctl > method to get this. ack > If so, i wonder if common.c is the correct place > for this, or if it should be moved into linkstate.c. You can then drop > the __. ok --=20 Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --5qr6a6va65al6rt2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEERBNZvwSgvmcMY/T74omh9DUaUbMFAl7EuHkACgkQ4omh9DUa UbOaLBAAh0tA+gDBCyLGNEaAVTVRH34zLhLAp9Pu/8Z6dYGN6ruMpLXOjsuNBxXD EDKZEreI9H6h/nZeGfIuicbsjINU6cF6F3I5Wv1MpdC6FtRKC3EMlMHQJdS6PJc5 AveRmCXuK32UiTV3UPvhdt/ohWZYdBIdhNQ7Fro6wKJjgfx9GIH+vxRT/l7GA/mG VGiermkSfyJOzk4x7muUHlKqblQivRxX10hc4D9gzQsaWvbvhzyuLyUA0ncmIbBd orDD3kEFaSosUA4FvWK0BQGvdkXSQlgv6zo9ii0G7HexMWQkDcwGEPDLqmPaNpaH Gj4VaIk55z53sft0+x5iHyacfE8yWjRLogMb+GZMxYEge3sXj8XnaW1Pqv93Eb+w 7Q5DRLlYt1wZ62cxQtx/T1ha8jDzGWosv0dqiG9oYMIa+4lBusTd5rj1t731Of/f znY0Il4eF8bTyrgXSSPJ47RvGHIy7U96V/nVQKQTkXsQeeR7+ufNUEgpVgE49O2i hQFkB3iXHXjzlBjIoCicmGqEPtxI5WK8taJ7zKK9+uTsT59rfX4YmMXk4uPfHGFe 2FEMRdUSPNNl+jkN7zZYj65znJ5EIXnYDc0LZG4gFJ4vSy524ZeKjPs/PEXjLYxL epTfO5yt2bD05dFqPyilpgBNAly9QYojlw/tGw4iG3de9ZBn3XA= =2CDe -----END PGP SIGNATURE----- --5qr6a6va65al6rt2--