From: Vinod Koul <vkoul@kernel.org>
To: Bard Liao <yung-chuan.liao@linux.intel.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
tiwai@suse.de, broonie@kernel.org, gregkh@linuxfoundation.org,
jank@cadence.com, srinivas.kandagatla@linaro.org,
rander.wang@linux.intel.com, ranjani.sridharan@linux.intel.com,
hui.wang@canonical.com, pierre-louis.bossart@linux.intel.com,
sanyog.r.kale@intel.com, slawomir.blauciak@intel.com,
mengdong.lin@intel.com, bard.liao@intel.com
Subject: Re: [PATCH 3/3] soundwire: add Slave sysfs support
Date: Wed, 20 May 2020 17:27:05 +0530 [thread overview]
Message-ID: <20200520115705.GV374218@vkoul-mobl.Dlink> (raw)
In-Reply-To: <20200518203551.2053-4-yung-chuan.liao@linux.intel.com>
On 19-05-20, 04:35, Bard Liao wrote:
> +int sdw_slave_sysfs_init(struct sdw_slave *slave)
> +{
> + int ret;
> +
> + ret = devm_device_add_groups(&slave->dev, slave_groups);
> + if (ret < 0)
> + return ret;
> +
> + ret = devm_device_add_group(&slave->dev, &sdw_slave_dev_attr_group);
> + if (ret < 0)
> + return ret;
> +
> + if (slave->prop.dp0_prop) {
> + ret = devm_device_add_group(&slave->dev, &dp0_group);
> + if (ret < 0)
> + return ret;
> + }
> +
> + if (slave->prop.source_ports || slave->prop.sink_ports) {
> + ret = sdw_slave_sysfs_dpn_init(slave);
> + if (ret < 0)
> + return ret;
> + }
> +
> + return 0;
> +}
> +
We have trailing line here
> +static int add_all_attributes(struct device *dev, int N, int dir)
> +{
> + struct attribute **dpn_attrs;
> + struct attribute_group *dpn_group;
> + int i = 0;
> + int ret;
> +
> + /* allocate attributes, last one is NULL */
> + dpn_attrs = devm_kcalloc(dev, SDW_DPN_ATTRIBUTES + 1,
> + sizeof(struct attribute *),
> + GFP_KERNEL);
> + if (!dpn_attrs)
> + return -ENOMEM;
> +
> + ret = max_word_attribute_alloc(dev, &dpn_attrs[i++],
> + N, dir, "%d\n");
> + if (ret < 0)
> + return ret;
> +
> + ret = min_word_attribute_alloc(dev, &dpn_attrs[i++],
> + N, dir, "%d\n");
> + if (ret < 0)
> + return ret;
> +
> + ret = words_attribute_alloc(dev, &dpn_attrs[i++],
> + N, dir, "%d\n");
> + if (ret < 0)
> + return ret;
> +
> + ret = type_attribute_alloc(dev, &dpn_attrs[i++],
> + N, dir, "%d\n");
> + if (ret < 0)
> + return ret;
> +
> + ret = max_grouping_attribute_alloc(dev, &dpn_attrs[i++],
> + N, dir, "%d\n");
> + if (ret < 0)
> + return ret;
> +
> + ret = simple_ch_prep_sm_attribute_alloc(dev, &dpn_attrs[i++],
> + N, dir, "%d\n");
> + if (ret < 0)
> + return ret;
> +
> + ret = ch_prep_timeout_attribute_alloc(dev, &dpn_attrs[i++],
> + N, dir, "%d\n");
> + if (ret < 0)
> + return ret;
> +
> + ret = imp_def_interrupts_attribute_alloc(dev, &dpn_attrs[i++],
> + N, dir, "0x%x\n");
> + if (ret < 0)
> + return ret;
> +
> + ret = min_ch_attribute_alloc(dev, &dpn_attrs[i++],
> + N, dir, "%d\n");
> + if (ret < 0)
> + return ret;
> +
> + ret = max_ch_attribute_alloc(dev, &dpn_attrs[i++],
> + N, dir, "%d\n");
> + if (ret < 0)
> + return ret;
> +
> + ret = channels_attribute_alloc(dev, &dpn_attrs[i++],
> + N, dir, "%d\n");
> + if (ret < 0)
> + return ret;
> +
> + ret = ch_combinations_attribute_alloc(dev, &dpn_attrs[i++],
> + N, dir, "%d\n");
> + if (ret < 0)
> + return ret;
> +
> + ret = max_async_buffer_attribute_alloc(dev, &dpn_attrs[i++],
> + N, dir, "%d\n");
> + if (ret < 0)
> + return ret;
> +
> + ret = block_pack_mode_attribute_alloc(dev, &dpn_attrs[i++],
> + N, dir, "%d\n");
> + if (ret < 0)
> + return ret;
> +
> + ret = port_encoding_attribute_alloc(dev, &dpn_attrs[i++],
> + N, dir, "%d\n");
> + if (ret < 0)
> + return ret;
> +
> + /* paranioa check for editing mistakes */
s/paranioa/paranoia
I found only these two nitpicks so I will go ahead and apply these and
fix them up.
--
~Vinod
next prev parent reply other threads:[~2020-05-20 11:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 20:35 [PATCH 0/3] soundwire: add sysfs support Bard Liao
2020-05-18 20:35 ` [PATCH 1/3] soundwire: disco: s/ch/channels/ Bard Liao
2020-05-18 20:35 ` [PATCH 2/3] soundwire: master: add sysfs support Bard Liao
2020-05-18 20:35 ` [PATCH 3/3] soundwire: add Slave " Bard Liao
2020-05-19 14:10 ` Greg KH
2020-05-20 11:57 ` Vinod Koul [this message]
2020-05-20 12:00 ` [PATCH 0/3] soundwire: add " Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200520115705.GV374218@vkoul-mobl.Dlink \
--to=vkoul@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bard.liao@intel.com \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hui.wang@canonical.com \
--cc=jank@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mengdong.lin@intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rander.wang@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=slawomir.blauciak@intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.de \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).