From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1A74C433E0 for ; Wed, 20 May 2020 16:37:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C7801206F1 for ; Wed, 20 May 2020 16:37:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589992662; bh=XKH8YKiyyHaQWTAdORIbFB6zMNH1cV6fYmuuCpvCKIs=; h=Date:From:To:Cc:Subject:In-Reply-To:List-ID:From; b=OSPJvhFmP638AISiLEnDPmpNkW01WAYeUNUvquRsNXZSEhYkRiDCZWja5iGavTKCw DUPMjNzaMs45bKH0jGbgr711wHh4AZguIWwNv2dQ9PP04SNCPUTFzKfQJ9WrwbsCS0 u6+0ywP8R8d+88a5fRskRILHSlKP/CsvRwoCJnuA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726940AbgETQhm (ORCPT ); Wed, 20 May 2020 12:37:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:35704 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726548AbgETQhl (ORCPT ); Wed, 20 May 2020 12:37:41 -0400 Received: from localhost (mobile-166-175-190-200.mycingular.net [166.175.190.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 391662065F; Wed, 20 May 2020 16:37:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589992661; bh=XKH8YKiyyHaQWTAdORIbFB6zMNH1cV6fYmuuCpvCKIs=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=KR8EoktP99veoD1Zs1CmCeyY/TAK9bDrMrkQZ+CAo88/EGCRblErKZf8uZGt++2sP nJ8OF2W1CbzcDYEL+0sESZH71kCTquvfLVn1gzMsyHzEN3R4AM2qls7n7MkD4W9Ykg QixYVtCNFahEP9l3xmIYFfFLDQS1AqsznQPGpyGg= Date: Wed, 20 May 2020 11:37:39 -0500 From: Bjorn Helgaas To: Thierry Reding Cc: Dinghao Liu , kjlu@umn.edu, Lorenzo Pieralisi , Rob Herring , Bjorn Helgaas , Jonathan Hunter , Vidya Sagar , Andrew Murray , linux-pci@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PCI: tegra: fix runtime pm imbalance on error Message-ID: <20200520163739.GA1100601@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200520095908.GD2136208@ulmo> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 20, 2020 at 11:59:08AM +0200, Thierry Reding wrote: > On Wed, May 20, 2020 at 04:52:23PM +0800, Dinghao Liu wrote: > > pm_runtime_get_sync() increments the runtime PM usage counter even > > it returns an error code. Thus a pairing decrement is needed on > > s/even it/even when it/ > > Might also be a good idea to use a different subject prefix because I > was almost not going to look at the other patch, taking this to be a > replacement for it. Amen. This would be a good change to start using "PCI: tegra194" or something for pcie-tegra194.c. Or will there be tegra195, tegra 196, etc added to this driver? Also, please capitalize the first word and "PM" in the subjects: PCI: tegra194: Fix runtime PM imbalance on error Bjorn