From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Ahmet Inan <inan@distec.de>,
Martin Fuzzey <martin.fuzzey@flowbird.group>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@collabora.com
Subject: Re: [PATCHv3 3/5] Input: EXC3000: add EXC80H60 and EXC80H84 support
Date: Wed, 20 May 2020 10:45:19 -0700 [thread overview]
Message-ID: <20200520174519.GV89269@dtor-ws> (raw)
In-Reply-To: <20200520153936.46869-4-sebastian.reichel@collabora.com>
Hi Sebastian,
On Wed, May 20, 2020 at 05:39:34PM +0200, Sebastian Reichel wrote:
>
> data->client = client;
> + data->info = device_get_match_data(&client->dev);
> + if (!data->info) {
> + enum eeti_dev_id eeti_dev_id =
> + i2c_match_id(exc3000_id, client)->driver_data;
I believe i2c devices can be instantiated via sysfs, so I think we
better handle case where we can't find matching id. Also driver_data is
enough to store a pointer, maybe we can have individual structures
instead of using an array and indexing here?
Thanks.
--
Dmitry
next prev parent reply other threads:[~2020-05-20 17:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 15:39 [PATCHv3 0/5] EXC3000 Updates Sebastian Reichel
2020-05-20 15:39 ` [PATCHv3 1/5] dt-bindings: touchscreen: Convert EETI EXC3000 touchscreen to json-schema Sebastian Reichel
2020-06-12 16:05 ` Sebastian Reichel
2020-05-20 15:39 ` [PATCHv3 2/5] Input: EXC3000: switch to i2c's probe_new API Sebastian Reichel
2020-05-20 16:50 ` Enric Balletbo i Serra
2020-05-20 17:31 ` Dmitry Torokhov
2020-05-20 15:39 ` [PATCHv3 3/5] Input: EXC3000: add EXC80H60 and EXC80H84 support Sebastian Reichel
2020-05-20 17:45 ` Dmitry Torokhov [this message]
2020-05-20 21:20 ` Sebastian Reichel
2020-05-21 6:12 ` Dmitry Torokhov
2020-05-20 15:39 ` [PATCHv3 4/5] Input: EXC3000: Add support to query model and fw_version Sebastian Reichel
2020-05-20 16:53 ` Enric Balletbo i Serra
2020-05-20 17:49 ` Dmitry Torokhov
2020-05-20 21:25 ` Sebastian Reichel
2020-05-21 5:54 ` Dmitry Torokhov
2020-05-20 15:39 ` [PATCHv3 5/5] Input: EXC3000: Add reset gpio support Sebastian Reichel
2020-05-20 16:54 ` Enric Balletbo i Serra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200520174519.GV89269@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=inan@distec.de \
--cc=kernel@collabora.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.fuzzey@flowbird.group \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).