From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Pavankumar Kondeti <pkondeti@codeaurora.org>
Cc: linux-kernel@vger.kernel.org,
Vinayak Menon <vinmenon@codeaurora.org>,
Ben Dooks <ben.dooks@codethink.co.uk>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
"Steven Rostedt (VMware)" <rostedt@goodmis.org>,
Liang Chen <cl@rock-chips.com>
Subject: Re: [PATCH] kthread: Use TASK_IDLE state for newly created kernel threads
Date: Wed, 20 May 2020 20:18:58 +0200 [thread overview]
Message-ID: <20200520181858.GA343493@kroah.com> (raw)
In-Reply-To: <1589975710-9283-1-git-send-email-pkondeti@codeaurora.org>
On Wed, May 20, 2020 at 05:25:09PM +0530, Pavankumar Kondeti wrote:
> When kernel threads are created for later use, they will be in
> TASK_UNINTERRUPTIBLE state until they are woken up. This results
> in increased loadavg and false hung task reports. To fix this,
> use TASK_IDLE state instead of TASK_UNINTERRUPTIBLE when
> a kernel thread schedules out for the first time.
>
> Signed-off-by: Pavankumar Kondeti <pkondeti@codeaurora.org>
> ---
> kernel/kthread.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/kthread.c b/kernel/kthread.c
> index bfbfa48..b74ed8e 100644
> --- a/kernel/kthread.c
> +++ b/kernel/kthread.c
> @@ -250,7 +250,7 @@ static int kthread(void *_create)
> current->vfork_done = &self->exited;
>
> /* OK, tell user we're spawned, wait for stop or wakeup */
> - __set_current_state(TASK_UNINTERRUPTIBLE);
> + __set_current_state(TASK_IDLE);
> create->result = current;
> /*
> * Thread is going to call schedule(), do not preempt it,
> @@ -428,7 +428,7 @@ static void __kthread_bind(struct task_struct *p, unsigned int cpu, long state)
>
> void kthread_bind_mask(struct task_struct *p, const struct cpumask *mask)
> {
> - __kthread_bind_mask(p, mask, TASK_UNINTERRUPTIBLE);
> + __kthread_bind_mask(p, mask, TASK_IDLE);
> }
>
> /**
> @@ -442,7 +442,7 @@ void kthread_bind_mask(struct task_struct *p, const struct cpumask *mask)
> */
> void kthread_bind(struct task_struct *p, unsigned int cpu)
> {
> - __kthread_bind(p, cpu, TASK_UNINTERRUPTIBLE);
> + __kthread_bind(p, cpu, TASK_IDLE);
> }
> EXPORT_SYMBOL(kthread_bind);
It's as if people never read mailing lists:
https://lore.kernel.org/r/DM6PR11MB3531D3B164357B2DC476102DDFC90@DM6PR11MB3531.namprd11.prod.outlook.com
Given that this is an identical resend of the previous patch, why are
you doing so, and what has changed since that original rejection?
greg k-h
next prev parent reply other threads:[~2020-05-20 18:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 11:55 [PATCH] kthread: Use TASK_IDLE state for newly created kernel threads Pavankumar Kondeti
2020-05-20 18:18 ` Greg Kroah-Hartman [this message]
2020-05-21 1:35 ` Pavan Kondeti
2020-05-21 5:56 ` Greg Kroah-Hartman
2020-05-21 9:51 ` Pavan Kondeti
2020-05-21 12:03 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200520181858.GA343493@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ben.dooks@codethink.co.uk \
--cc=cl@rock-chips.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=pkondeti@codeaurora.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=vinmenon@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).