From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64CC1C433E0 for ; Wed, 20 May 2020 18:59:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 462C1207D3 for ; Wed, 20 May 2020 18:59:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BSaIZLFs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726775AbgETS7l (ORCPT ); Wed, 20 May 2020 14:59:41 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:53205 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726548AbgETS7l (ORCPT ); Wed, 20 May 2020 14:59:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590001179; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pt7bvYYawn3sgSHXJPdnah6IgJnyPNreqW2IcI8c10c=; b=BSaIZLFs2UUm5OHr9TY0MJLPHySUrewtxMoL+OGhQcoFGX182Bsvk5jBfGq4B+ENodgpfW k+wh17K3P9GWeQOxnVJXrbxuoqeEUYWvpesJLwG/ZGIVDELF92SUIseWkxWwKChOu8kL6r POCLWa1q1v3bbrUZLCUaVsFyatQcGjk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-464-xP25d97nM3SYT0bV7BcgHg-1; Wed, 20 May 2020 14:59:34 -0400 X-MC-Unique: xP25d97nM3SYT0bV7BcgHg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D5D491800D42; Wed, 20 May 2020 18:59:32 +0000 (UTC) Received: from madcap2.tricolour.ca (unknown [10.10.110.46]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 40BFF7D96E; Wed, 20 May 2020 18:59:25 +0000 (UTC) Date: Wed, 20 May 2020 14:59:22 -0400 From: Richard Guy Briggs To: Steve Grubb Cc: linux-audit@redhat.com, Paul Moore , fw@strlen.de, LKML , netfilter-devel@vger.kernel.org, twoerner@redhat.com, Eric Paris , tgraf@infradead.org Subject: Re: [PATCH ghak25 v6] audit: add subj creds to NETFILTER_CFG record to cover async unregister Message-ID: <20200520185922.vnutg5z3hwp7grjm@madcap2.tricolour.ca> References: <20200520165510.4l4q47vq6fyx7hh6@madcap2.tricolour.ca> <17476338.hsbNre52Up@x2> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17476338.hsbNre52Up@x2> User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-05-20 14:51, Steve Grubb wrote: > On Wednesday, May 20, 2020 2:40:45 PM EDT Paul Moore wrote: > > On Wed, May 20, 2020 at 12:55 PM Richard Guy Briggs wrote: > > > On 2020-05-20 12:51, Richard Guy Briggs wrote: > > > > Some table unregister actions seem to be initiated by the kernel to > > > > garbage collect unused tables that are not initiated by any userspace > > > > actions. It was found to be necessary to add the subject credentials > > > > to cover this case to reveal the source of these actions. A sample > > > > record: > > > > > > > > The uid, auid, tty, ses and exe fields have not been included since > > > > they > > > > are in the SYSCALL record and contain nothing useful in the non-user > > > > context. > > > > > > > > type=NETFILTER_CFG msg=audit(2020-03-11 21:25:21.491:269) : table=nat > > > > family=bridge entries=0 op=unregister pid=153 > > > > subj=system_u:system_r:kernel_t:s0 comm=kworker/u4:2 > > > > FWIW, that record looks good. > > It's severely broken > > cat log.file > type=NETFILTER_CFG msg=audit(2020-03-11 21:25:21.491:269) : table=nat > family=bridge entries=0 op=unregister pid=153 > subj=system_u:system_r:kernel_t:s0 comm=kworker/u4:2 > > ausearch -if log.file --format text > At 19:33:40 12/31/1969 did-unknown > > ausearch -if log.file --format csv > NODE,EVENT,DATE,TIME,SERIAL_NUM,EVENT_KIND,SESSION,SUBJ_PRIME,SUBJ_SEC,SUBJ_KIND,ACTION,RESULT,OBJ_PRIME,OBJ_SEC,OBJ_KIND,HOW > error normalizing NETFILTER_CFG > ,NETFILTER_CFG,12/31/1969,19:33:40,0,,,,,,,,,, > > This is unusable. This is why the bug was filed in the first place. Have you applied this patchset? https://www.redhat.com/archives/linux-audit/2020-May/msg00072.html AUDIT_EVENT_LISTENER is also broken without this first patch. > -Steve > > > > > Signed-off-by: Richard Guy Briggs > > > > > > Self-NACK. I forgot to remove cred and tty declarations. - RGB -- Richard Guy Briggs Sr. S/W Engineer, Kernel Security, Base Operating Systems Remote, Ottawa, Red Hat Canada IRC: rgb, SunRaycer Voice: +1.647.777.2635, Internal: (81) 32635