From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: agross@kernel.org, bjorn.andersson@linaro.org, kishon@ti.com,
vkoul@kernel.org, robh+dt@kernel.org
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, bryan.odonoghue@linaro.org
Subject: [PATCH 0/2] phy: qcom-usb-hs: Add DT controlled VBUS pullup waggle
Date: Thu, 21 May 2020 01:50:29 +0100 [thread overview]
Message-ID: <20200521005031.747162-1-bryan.odonoghue@linaro.org> (raw)
On an MSM8939 we have a system behind both a type-c controller and a USB
Hub. VBUS is not connected to the PHY and no GPIO is available to signal
VBUS state to the USB controller and PHY.
In this case we've used USB role-switching to transition between
host and device mode.
The current code in qcom-usb-hs only touches the VBUS pullup control bits
if we have an extcon but, setting those bits is still required on the
example I gave of the MSM8939.
This series takes the downstream concept of a DT driven flag for the VBUS
pullup bits and applies it to upstream in the poweron/poweroff path of the
PHY.
I've opted to unset the bits on PHY poweroff though in downstream the bits
are only ever switched on if the flag is present, downstream never switches
the bits off again. I think though, setting the bits off on PHY power-off
is the right thing to do, so I've done it.
Bryan O'Donoghue (2):
dt-bindings: phy-qcom-usb-hs-phy: Add qcom,enable-vbus-pullup
phy: qcom-usb-hs: Add qcom,enable-vbus-pullup support
.../bindings/phy/qcom,usb-hs-phy.txt | 8 +++++
drivers/phy/qualcomm/phy-qcom-usb-hs.c | 36 +++++++++++++++++++
2 files changed, 44 insertions(+)
--
2.25.1
next reply other threads:[~2020-05-21 0:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-21 0:50 Bryan O'Donoghue [this message]
2020-05-21 0:50 ` [PATCH 1/2] dt-bindings: phy-qcom-usb-hs-phy: Add qcom,enable-vbus-pullup Bryan O'Donoghue
2020-05-28 22:34 ` Rob Herring
2020-05-21 0:50 ` [PATCH 2/2] phy: qcom-usb-hs: Add qcom,enable-vbus-pullup support Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200521005031.747162-1-bryan.odonoghue@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).