Re: [PATCH 2/6] soc: ti: omap-prm: Add basic power domain support

From: kbuild test robot <lkp@intel.com>
To: Tony Lindgren <tony@atomide.com>, linux-omap@vger.kernel.org
Cc: kbuild-all@lists.01.org, "Andrew F . Davis" <afd@ti.com>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Suman Anna <s-anna@ti.com>, Tero Kristo <t-kristo@ti.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Rob Herring <robh@kernel.org>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 2/6] soc: ti: omap-prm: Add basic power domain support
Date: Thu, 21 May 2020 12:53:30 +0800	[thread overview]
Message-ID: <202005211220.vpWmzMaT%lkp@intel.com> (raw)
In-Reply-To: <20200520211334.61814-3-tony@atomide.com>

[-- Attachment #1: Type: text/plain, Size: 2779 bytes --]

Hi Tony,

I love your patch! Perhaps something to improve:

[auto build test WARNING on omap/for-next]
[also build test WARNING on robh/for-next keystone/next v5.7-rc6 next-20200519]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Tony-Lindgren/Add-initial-genpd-support-for-omap-PRM-driver/20200521-063328
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap.git for-next
config: arm-defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

drivers/soc/ti/omap_prm.c: In function 'omap_prm_domain_detach_dev':
>> drivers/soc/ti/omap_prm.c:347:26: warning: variable 'prmd' set but not used [-Wunused-but-set-variable]
347 |  struct omap_prm_domain *prmd;
|                          ^~~~
At top level:
drivers/soc/ti/omap_prm.c:123:21: warning: 'omap_prm_onoff_noauto' defined but not used [-Wunused-const-variable=]
123 | omap_prm_domain_map omap_prm_onoff_noauto = {
|                     ^~~~~~~~~~~~~~~~~~~~~
drivers/soc/ti/omap_prm.c:115:21: warning: 'omap_prm_nooff' defined but not used [-Wunused-const-variable=]
115 | omap_prm_domain_map omap_prm_nooff = {
|                     ^~~~~~~~~~~~~~
drivers/soc/ti/omap_prm.c:107:21: warning: 'omap_prm_noinact' defined but not used [-Wunused-const-variable=]
107 | omap_prm_domain_map omap_prm_noinact = {
|                     ^~~~~~~~~~~~~~~~
drivers/soc/ti/omap_prm.c:99:21: warning: 'omap_prm_all' defined but not used [-Wunused-const-variable=]
99 | omap_prm_domain_map omap_prm_all = {
|                     ^~~~~~~~~~~~

vim +/prmd +347 drivers/soc/ti/omap_prm.c

   342	
   343	static void omap_prm_domain_detach_dev(struct generic_pm_domain *domain,
   344					       struct device *dev)
   345	{
   346		struct generic_pm_domain_data *genpd_data;
 > 347		struct omap_prm_domain *prmd;
   348	
   349		prmd = genpd_to_prm_domain(domain);
   350	
   351		genpd_data = dev_gpd_data(dev);
   352		genpd_data->data = NULL;
   353	}
   354	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 50472 bytes --]