From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15213C433E0 for ; Thu, 21 May 2020 20:00:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DA5F32084C for ; Thu, 21 May 2020 20:00:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="arknal30" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730281AbgEUUAQ (ORCPT ); Thu, 21 May 2020 16:00:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728635AbgEUUAP (ORCPT ); Thu, 21 May 2020 16:00:15 -0400 Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D649C061A0E for ; Thu, 21 May 2020 13:00:15 -0700 (PDT) Received: by mail-pl1-x641.google.com with SMTP id u22so3321492plq.12 for ; Thu, 21 May 2020 13:00:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ulvs3QovAejney8/yaIpAssOKiAEegTNo53VZEhb45g=; b=arknal30qqyUt9Uultoin1W2eEnpjZOh2M50gfKNKsh2c05XoVw664fE7SmegYbFqL 1jYIOZFK3qvFTzSvZb1a/0TeRh7x1QwAIQ0yudjxW7Ohj3kbGc5wR0AnbDcmCs1eSjqo W43A5+fzigzpmM6CKgu4thGrBpPlM6zXWyDTc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ulvs3QovAejney8/yaIpAssOKiAEegTNo53VZEhb45g=; b=GRojIjkTP6iqM0i+Wd3zmbVUQdaYRi9x4xJUWCNaz+J/IDZscnkDEdh01B+bB6GuUv lZh4+sxP3Utt/6CnOr2xyqHcgZCa52ibL3NUGtMd9WyAMiZ5NZwi9gUUa91XtAtS6CJQ RQDcVj6FygUkbX7smJhj+6DDTRj0OmJQYceKbY+xgzOmo7piLquzVJLtNBRP843Kxsw6 yu5nhTMjvX8I1/Uc48fX+1yG6G4erx4G1vb7pvhBdrycOg+ReMiYV9WE0zQ6DLwi/blJ R/+ILU5loQdX3PE3QS2iXoz3P6HPuom8toqj0z+rGOCTVn0kQqwq949pVliPg3iHeG9N JOpw== X-Gm-Message-State: AOAM531CcUkSqVDWti7acs8dyQFtIZSmTUJvMEYRpjwSkv/7ey+F22uV sKmVNVJkpOJLxJvwHBkBwPfTww== X-Google-Smtp-Source: ABdhPJygsq417Det10M2bkwgpyvuYKzPNse7VchUrWVJXxj4vjS2acqQQI4FoLCeiaO83wNsdfO0qw== X-Received: by 2002:a17:90a:4fc6:: with SMTP id q64mr241368pjh.34.1590091215159; Thu, 21 May 2020 13:00:15 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id 188sm5122610pfu.165.2020.05.21.13.00.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2020 13:00:14 -0700 (PDT) Date: Thu, 21 May 2020 13:00:12 -0700 From: Kees Cook To: Kristen Carlson Accardi Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, Masahiro Yamada , Michal Marek , x86@kernel.org, "H. Peter Anvin" , arjan@linux.intel.com, linux-kernel@vger.kernel.org, kernel-hardening@lists.openwall.com, rick.p.edgecombe@intel.com, Tony Luck , linux-kbuild@vger.kernel.org Subject: Re: [PATCH v2 4/9] x86: Makefile: Add build and config option for CONFIG_FG_KASLR Message-ID: <202005211255.33E27D05@keescook> References: <20200521165641.15940-1-kristen@linux.intel.com> <20200521165641.15940-5-kristen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200521165641.15940-5-kristen@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 21, 2020 at 09:56:35AM -0700, Kristen Carlson Accardi wrote: > Allow user to select CONFIG_FG_KASLR if dependencies are met. Change > the make file to build with -ffunction-sections if CONFIG_FG_KASLR > > Signed-off-by: Kristen Carlson Accardi > Reviewed-by: Tony Luck > Tested-by: Tony Luck > --- > Makefile | 4 ++++ > arch/x86/Kconfig | 13 +++++++++++++ > 2 files changed, 17 insertions(+) > > diff --git a/Makefile b/Makefile > index 04f5662ae61a..28e515baa824 100644 > --- a/Makefile > +++ b/Makefile > @@ -862,6 +862,10 @@ ifdef CONFIG_LIVEPATCH > KBUILD_CFLAGS += $(call cc-option, -flive-patching=inline-clone) > endif > > +ifdef CONFIG_FG_KASLR > +KBUILD_CFLAGS += -ffunction-sections > +endif > + > # arch Makefile may override CC so keep this after arch Makefile is included > NOSTDINC_FLAGS += -nostdinc -isystem $(shell $(CC) -print-file-name=include) > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index 2d3f963fd6f1..50e83ea57d70 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -2183,6 +2183,19 @@ config RANDOMIZE_BASE > > If unsure, say Y. > > +config FG_KASLR > + bool "Function Granular Kernel Address Space Layout Randomization" > + depends on $(cc-option, -ffunction-sections) > + depends on RANDOMIZE_BASE && X86_64 > + help > + This option improves the randomness of the kernel text > + over basic Kernel Address Space Layout Randomization (KASLR) > + by reordering the kernel text at boot time. This feature > + uses information generated at compile time to re-layout the > + kernel text section at boot time at function level granularity. > + > + If unsure, say N. > + > # Relocation on x86 needs some additional build support > config X86_NEED_RELOCS > def_bool y Kconfig bikeshedding: how about putting FG_KASLR in arch/Kconfig, add a "depends on ARCH_HAS_FG_KASLR", and remove the arch-specific depends. Then in arch/x86 have ARCH_HAS_FG_KASLR as a def_bool y with the RANDOMIZE_BASE && X86_64 depends. This will more cleanly split the build elements (compiler flags) from the arch elements (64-bit x86, arch-specific flags, etc). With that split out: Reviewed-by: Kees Cook -- Kees Cook