From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 266E1C433E0 for ; Thu, 21 May 2020 17:28:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D95B320829 for ; Thu, 21 May 2020 17:28:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590082100; bh=pRt37ocE9vbggyrqslixMeQ2DbUZaL7la/D9a2Hyc0Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=TS/5Pdcam4c8nfsStr471bn3sdj2rpG3WkDhOc/+XMgLoDEzHyYzjqHoQ9TUilwrz eRijVTHseZce6VlbWHQz9nvB+zESR1bWI88/emiOmV5ZmJcElL8uSwHhKOVaJ/Vvg+ FOK11oq42BmgLem1GNn8+MeoCBGBFYBuqPLoNuPs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729967AbgEUR2U (ORCPT ); Thu, 21 May 2020 13:28:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:49240 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727955AbgEUR2T (ORCPT ); Thu, 21 May 2020 13:28:19 -0400 Received: from quaco.ghostprotocols.net (unknown [179.97.37.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 19F742072C; Thu, 21 May 2020 17:28:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590082099; bh=pRt37ocE9vbggyrqslixMeQ2DbUZaL7la/D9a2Hyc0Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ckSLP4YKyS88FddhbJdgMzUz8vGOQPYYrpD0JarsGmKMcHdz/RvArC57UE0IcAS8K j8sNGhCwSlhy/FJEUDjB/PMevl5125W9NQB2Ff9idCtW8N1xT8wxFW4FYm/z/ueLFL gfjwiD3laRWqiM6D+HT/FaKaf/zqbHKnwPG1Q6DQ= Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id EB8D840AFD; Thu, 21 May 2020 14:28:16 -0300 (-03) Date: Thu, 21 May 2020 14:28:16 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Jiri Olsa , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Namhyung Kim , Song Liu , Andrii Nakryiko , Kajol Jain , Andi Kleen , John Garry , Jin Yao , Kan Liang , Cong Wang , Kim Phillips , Paul Clarke , Srikar Dronamraju , LKML , Networking , bpf , linux-perf-users , Vince Weaver , Stephane Eranian Subject: Re: [PATCH 5/7] perf metricgroup: Remove duped metric group events Message-ID: <20200521172816.GE14034@kernel.org> References: <20200520072814.128267-1-irogers@google.com> <20200520072814.128267-6-irogers@google.com> <20200520134847.GM157452@krava> <20200520220912.GP157452@krava> <20200521105412.GS157452@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, May 21, 2020 at 10:26:02AM -0700, Ian Rogers escreveu: > On Thu, May 21, 2020 at 3:54 AM Jiri Olsa wrote: > > ok, I misunderstood and thought you would colaps also M3 to > > have A,B computed via M1 group and with separate D ... > > > > thanks a lot for the explanation, it might be great to have it > > in the comments/changelog or even man page > > Thanks Jiri! Arnaldo do you want me to copy the description above into > the commit message of this change and resend? Send as a follow on patch, please. - Arnaldo > This patch adds some description to find_evsel_group, this is expanded > by the next patch that adds the two command line flags: > https://lore.kernel.org/lkml/20200520072814.128267-7-irogers@google.com/ > When writing the patches it wasn't clear to me how much detail to > include in say the man pages. > > Thanks, > Ian