From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 227CCC433E1 for ; Thu, 21 May 2020 17:46:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0481720890 for ; Thu, 21 May 2020 17:46:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728670AbgEURqm (ORCPT ); Thu, 21 May 2020 13:46:42 -0400 Received: from mga01.intel.com ([192.55.52.88]:15985 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727966AbgEURql (ORCPT ); Thu, 21 May 2020 13:46:41 -0400 IronPort-SDR: hdrl0efVNCtzijIvRvUA9sobGXAD+uu8srkyoBYHKzJv6IMzaOdwdI760n3PL9OoVGe6r+ygu+ CHtFdK/Tbtbg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 May 2020 10:46:41 -0700 IronPort-SDR: 8aX85jWXvmSD89qEJZFBauvvMIasp7hathyri35IeY5Cbx6az3vB81oL6JWPo+QsiQOqMGBufp R9cDjq237gNA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,418,1583222400"; d="scan'208";a="412483262" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga004.jf.intel.com with ESMTP; 21 May 2020 10:46:35 -0700 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1jbpHC-0085Co-PX; Thu, 21 May 2020 20:46:38 +0300 Date: Thu, 21 May 2020 20:46:38 +0300 From: Andy Shevchenko To: Serge Semin Cc: Mark Brown , Serge Semin , Georgy Vlasov , Ramil Zaripov , Alexey Malahov , Maxim Kaurkin , Pavel Parkhomenko , Ekaterina Skachko , Vadim Vlasov , Alexey Kolotnikov , Thomas Bogendoerfer , Paul Burton , Ralf Baechle , Arnd Bergmann , Rob Herring , linux-mips@vger.kernel.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 00/16] spi: dw: Add generic DW DMA controller support Message-ID: <20200521174638.GQ1634618@smile.fi.intel.com> References: <20200521012206.14472-1-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200521012206.14472-1-Sergey.Semin@baikalelectronics.ru> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 21, 2020 at 04:21:50AM +0300, Serge Semin wrote: > Baikal-T1 SoC provides a DW DMA controller to perform low-speed peripherals > Mem-to-Dev and Dev-to-Mem transaction. This is also applicable to the DW > APB SSI devices embedded into the SoC. Currently the DMA-based transfers > are supported by the DW APB SPI driver only as a middle layer code for > Intel MID/Elkhart PCI devices. Seeing the same code can be used for normal > platform DMAC device we introduced a set of patches to fix it within this > series. > > First of all we need to add the Tx and Rx DMA channels support into the DW > APB SSI binding. Then there are several fixes and cleanups provided as a > initial preparation for the Generic DMA support integration: add Tx/Rx > finish wait methods, clear DMAC register when done or stopped, Fix native > CS being unset, enable interrupts in accordance with DMA xfer mode, > discard static DW DMA slave structures, discard unused void priv pointer > and dma_width member of the dw_spi structure, provide the DMA Tx/Rx burst > length parametrisation and make sure it's optionally set in accordance > with the DMA max-burst capability. > > In order to have the DW APB SSI MMIO driver working with DMA we need to > initialize the paddr field with the physical base address of the DW APB SSI > registers space. Then we unpin the Intel MID specific code from the > generic DMA one and placed it into the spi-dw-pci.c driver, which is a > better place for it anyway. After that the naming cleanups are performed > since the code is going to be used for a generic DMAC device. Finally the > Generic DMA initialization can be added to the generic version of the > DW APB SSI IP. > > Last but not least we traditionally convert the legacy plain text-based > dt-binding file with yaml-based one and as a cherry on a cake replace > the manually written DebugFS registers read method with a ready-to-use > for the same purpose regset32 DebugFS interface usage. I have given tags where I agree with content and I left disputed ones untouched (1st patch, nevertheless, is fine for me, but I'm waiting for Feng). So, now it seems settled in a way that I will send couple of cleanups afterwards to avoid blocking this series to go. Thanks for your work! > This patchset is rebased and tested on the spi/for-next (5.7-rc5): > base-commit: fe9fce6b2cf3 ("Merge remote-tracking branch 'spi/for-5.8' into spi-next") > > Link: https://lore.kernel.org/linux-spi/20200508132943.9826-1-Sergey.Semin@baikalelectronics.ru/ > Changelog v2: > - Rebase on top of the spi repository for-next branch. > - Move bindings conversion patch to the tail of the series. > - Move fixes to the head of the series. > - Apply as many changes as possible to be applied the Generic DMA > functionality support is added and the spi-dw-mid is moved to the > spi-dw-dma driver. > - Discard patch "spi: dw: Fix dma_slave_config used partly uninitialized" > since the problem has already been fixed. > - Add new patch "spi: dw: Discard unused void priv pointer". > - Add new patch "spi: dw: Discard dma_width member of the dw_spi structure". > n_bytes member of the DW SPI data can be used instead. > - Build the DMA functionality into the DW APB SSI core if required instead > of creating a separate kernel module. > - Use conditional statement instead of the ternary operator in the ref > clock getter. > > Link: https://lore.kernel.org/linux-spi/20200515104758.6934-1-Sergey.Semin@baikalelectronics.ru/ > Changelog v3: > - Use spi_delay_exec() method to wait for the DMA operation completion. > - Explicitly initialize the dw_dma_slave members on stack. > - Discard the dws->fifo_len utilization in the Tx FIFO DMA threshold > setting from the patch where we just add the default burst length > constants. > - Use min() method to calculate the optimal burst values. > - Add new patch which moves the spi-dw.c source file to spi-dw-core.c in > order to preserve the DW APB SSI core driver name. > - Add commas in the debugfs_reg32 structure initializer and after the last > entry of the dw_spi_dbgfs_regs array. > > Co-developed-by: Georgy Vlasov > Signed-off-by: Georgy Vlasov > Co-developed-by: Ramil Zaripov > Signed-off-by: Ramil Zaripov > Signed-off-by: Serge Semin > Cc: Alexey Malahov > Cc: Maxim Kaurkin > Cc: Pavel Parkhomenko > Cc: Ekaterina Skachko > Cc: Vadim Vlasov > Cc: Alexey Kolotnikov > Cc: Thomas Bogendoerfer > Cc: Paul Burton > Cc: Ralf Baechle > Cc: Arnd Bergmann > Cc: Andy Shevchenko > Cc: Rob Herring > Cc: linux-mips@vger.kernel.org > Cc: linux-spi@vger.kernel.org > Cc: devicetree@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > > Serge Semin (16): > spi: dw: Add Tx/Rx finish wait methods to the MID DMA > spi: dw: Enable interrupts in accordance with DMA xfer mode > spi: dw: Discard static DW DMA slave structures > spi: dw: Discard unused void priv pointer > spi: dw: Discard dma_width member of the dw_spi structure > spi: dw: Parameterize the DMA Rx/Tx burst length > spi: dw: Use DMA max burst to set the request thresholds > spi: dw: Fix Rx-only DMA transfers > spi: dw: Add core suffix to the DW APB SSI core source file > spi: dw: Move Non-DMA code to the DW PCIe-SPI driver > spi: dw: Remove DW DMA code dependency from DW_DMAC_PCI > spi: dw: Add DW SPI DMA/PCI/MMIO dependency on the DW SPI core > spi: dw: Cleanup generic DW DMA code namings > spi: dw: Add DMA support to the DW SPI MMIO driver > spi: dw: Use regset32 DebugFS method to create regdump file > dt-bindings: spi: Convert DW SPI binding to DT schema > > .../bindings/spi/snps,dw-apb-ssi.txt | 44 --- > .../bindings/spi/snps,dw-apb-ssi.yaml | 127 ++++++++ > .../devicetree/bindings/spi/spi-dw.txt | 24 -- > drivers/spi/Kconfig | 15 +- > drivers/spi/Makefile | 5 +- > drivers/spi/{spi-dw.c => spi-dw-core.c} | 88 ++---- > drivers/spi/{spi-dw-mid.c => spi-dw-dma.c} | 276 +++++++++++------- > drivers/spi/spi-dw-mmio.c | 4 + > drivers/spi/spi-dw-pci.c | 50 +++- > drivers/spi/spi-dw.h | 33 ++- > 10 files changed, 407 insertions(+), 259 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.txt > create mode 100644 Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > delete mode 100644 Documentation/devicetree/bindings/spi/spi-dw.txt > rename drivers/spi/{spi-dw.c => spi-dw-core.c} (82%) > rename drivers/spi/{spi-dw-mid.c => spi-dw-dma.c} (53%) > > -- > 2.25.1 > -- With Best Regards, Andy Shevchenko