From: robh@kernel.org
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Marc Zyngier <maz@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
devicetree@vger.kernel.org, Ulf Hansson <ulf.hansson@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v2 2/9] dt-bindings: gpio: Convert mrvl-gpio to json-schema
Date: Thu, 21 May 2020 13:57:48 -0600 [thread overview]
Message-ID: <20200521195748.GA2795626@bogus> (raw)
In-Reply-To: <20200521091356.2211020-3-lkundrak@v3.sk>
On Thu, 21 May 2020 11:13:49 +0200, Lubomir Rintel wrote:
> This converts the mrvl-gpio binding to DT schema format using json-schema.
>
> Various fixes were done during the conversion, such as adding more
> properties that are in fact mandatory or extending the examples to
> include child nodes with extra GPIO blocks.
>
> The compatible strings are a mess. It is not clear why so many of them
> are needed; the driver doesn't really seem to differentiate between the
> models. Some of them, like marvell,pxa93x-gpio and marvell,pxa1928-gpio
> are not used at all, so it's not known how many interrupts they utilize.
> On the other hand, mrvl,pxa-gpio has been seen in the tree, but it
> doesn't end up in any actual DTB file.
>
> In any case -- the schema merely copies whatever was in the original
> binding document, so it's hopefully no more wrong that the original.
>
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
>
> ---
> Changes since v1:
> - Drop marvell,pxa1928-gpio
> - Drop ranges from example with no gcb child nodes
> - Add default GPL-2.0-only license tag
> - Fill in maintainers from MAINTAINERS file
>
> .../devicetree/bindings/gpio/mrvl-gpio.txt | 48 -----
> .../devicetree/bindings/gpio/mrvl-gpio.yaml | 174 ++++++++++++++++++
> 2 files changed, 174 insertions(+), 48 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/gpio/mrvl-gpio.txt
> create mode 100644 Documentation/devicetree/bindings/gpio/mrvl-gpio.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/gpio/mrvl-gpio.example.dt.yaml: gpio@40e00000: 'ranges' is a required property
See https://patchwork.ozlabs.org/patch/1295044
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure dt-schema is up to date:
pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2020-05-21 19:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-21 9:13 [PATCH 0/9] DT: Improve validation for Marvell SoCs Lubomir Rintel
2020-05-21 9:13 ` [PATCH v2 1/9] dt-bindings: mmc: Convert sdhci-pxa to json-schema Lubomir Rintel
2020-05-27 7:59 ` Ulf Hansson
2020-05-28 22:54 ` Rob Herring
2020-05-29 11:10 ` Ulf Hansson
2020-05-21 9:13 ` [PATCH v2 2/9] dt-bindings: gpio: Convert mrvl-gpio " Lubomir Rintel
2020-05-21 19:57 ` robh [this message]
2020-05-21 9:13 ` [PATCH v2 3/9] dt-bindings: i2c: Convert i2c-pxa " Lubomir Rintel
2020-05-28 22:57 ` Rob Herring
2020-05-21 9:13 ` [PATCH v2 4/9] dt-bindings: interrupt-controller: Convert mrvl,intc " Lubomir Rintel
2020-05-21 9:13 ` [PATCH v2 5/9] dt-bindings: media: Convert marvell,mmp2-ccic " Lubomir Rintel
2020-05-28 22:59 ` Rob Herring
2020-05-21 9:13 ` [PATCH v2 6/9] dt-bindings: rtc: Convert sa1100-rtc " Lubomir Rintel
2020-05-21 9:13 ` [PATCH v2 7/9] dt-bindings: spi: Convert spi-pxa2xx " Lubomir Rintel
2020-05-28 23:03 ` Rob Herring
2020-05-21 9:13 ` [PATCH v2 8/9] dt-bindings: timer: Convert mrvl,mmp-timer " Lubomir Rintel
2020-05-21 9:13 ` [PATCH v2 9/9] dt-bindings: usb: Convert ehci-mv " Lubomir Rintel
2020-05-28 23:05 ` Rob Herring
2020-05-28 22:52 ` [PATCH 0/9] DT: Improve validation for Marvell SoCs Rob Herring
2020-05-30 18:14 ` Lubomir Rintel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200521195748.GA2795626@bogus \
--to=robh@kernel.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=bgolaszewski@baylibre.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jason@lakedaemon.net \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=maz@kernel.org \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).