From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58FD3C433E1 for ; Fri, 22 May 2020 17:22:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3AFCD207BC for ; Fri, 22 May 2020 17:22:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="QdOKlWAU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730765AbgEVRWz (ORCPT ); Fri, 22 May 2020 13:22:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730733AbgEVRWy (ORCPT ); Fri, 22 May 2020 13:22:54 -0400 Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65048C08C5C0 for ; Fri, 22 May 2020 10:22:54 -0700 (PDT) Received: by mail-pg1-x542.google.com with SMTP id w20so260164pga.6 for ; Fri, 22 May 2020 10:22:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=amaxCECevOSXJrGQyIuXx97hyD0UaNdLUI7ilZbNErE=; b=QdOKlWAUfaOgmRv2+ys3+AI8VRaQjQGwiQE2Q9ixqsSc47+pg8ot2k8eV9uY4lzp++ i0TuH4yEnQR5YabGAbnFYlP73coOX4eGfIXprx+hq/fwlynG47mBziM1nHeMmGvyGC/p xuiDofpqRF65/vevf6CbCee7998FCjaJgYfFs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=amaxCECevOSXJrGQyIuXx97hyD0UaNdLUI7ilZbNErE=; b=BfIuzL/aang8UVvTy+i299m43x2qOE5N1Og5s2x2f2jLv9S0deB58xW1ahULZPrpkn 0FnNs8jFbVCtIqDE/qlw/BPZj5vOkIyA89JmH2N8DbSYILRkkF3bfsT6a3bLk+xTKaCP MCKcdX2ac/vBMtN07TLaFdSkhYneh1SZBGRg/lwLJC4R/uW4xj5nQkAgjv1kqy3CAM98 JemX6pjJGiK4i250ga0FgtxB5a2JJOrFoE37ajqOlSK9aVSs6ZUKQQ50YPYGc4ew0h+R nuW2/wWliYUzb64R1tNXEvBHB2wBoqwiRTY8bLdbHX9Pr0qT5YPrHd682pSYePi8C3Ic XG8A== X-Gm-Message-State: AOAM530QAsBXwOlUaSsFI95HcI9fRxmgZbti/54ooVqcvlTKUSz1BJV8 ngaK9A2Ud1/OLWjgO7O3Sb8LOA== X-Google-Smtp-Source: ABdhPJxp9FF04TnejNRz/NvrR22fKHIQ7m8bWd6qeiuqYrLZnucmLNFQPYrNAd8AJZHV+du2CRuRLQ== X-Received: by 2002:aa7:9ab6:: with SMTP id x22mr4840028pfi.136.1590168173772; Fri, 22 May 2020 10:22:53 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id d22sm6676581pgh.64.2020.05.22.10.22.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 May 2020 10:22:52 -0700 (PDT) Date: Fri, 22 May 2020 10:22:51 -0700 From: Kees Cook To: Peter Zijlstra Cc: Yu-cheng Yu , x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin , Weijiang Yang Subject: Re: [RFC PATCH 5/5] selftest/x86: Add CET quick test Message-ID: <202005221020.B578B8C6@keescook> References: <20200521211720.20236-1-yu-cheng.yu@intel.com> <20200521211720.20236-6-yu-cheng.yu@intel.com> <20200522092848.GJ325280@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200522092848.GJ325280@hirez.programming.kicks-ass.net> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 22, 2020 at 11:28:48AM +0200, Peter Zijlstra wrote: > Get asm/asm.h into userspace and then write something like: Yeah, selftests is going to start suffering from the same "tools/ header duplication" problem. I've also had cases (see the logic in the Makefile in selftests/x86) where selftests is duplicating existing Kconfig and Makefile logic ("can I build this way?") But yes, I think getting a copy of asm.h would be nice here. I don't think the WRITE_ONCE() is needed in this particular case. Hmm. -- Kees Cook