From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Guru Das Srinagesh <gurus@codeaurora.org>
Cc: linux-pwm@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>,
Subbaraman Narayanamurthy <subbaram@codeaurora.org>,
David Collins <collinsd@codeaurora.org>,
linux-kernel@vger.kernel.org,
Fabrice Gasnier <fabrice.gasnier@st.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Joe Perches <joe@perches.com>
Subject: Re: [PATCH v13 11/11] pwm: core: Convert period and duty cycle to u64
Date: Fri, 22 May 2020 15:26:31 +0200 [thread overview]
Message-ID: <20200522132631.sazoyq2d3krdvg6o@pengutronix.de> (raw)
In-Reply-To: <0ff7cc052b38411cba050d7066f17c9062a9101a.1587523702.git.gurus@codeaurora.org>
On Tue, Apr 21, 2020 at 07:57:23PM -0700, Guru Das Srinagesh wrote:
> Because period and duty cycle are defined as ints with units of
> nanoseconds, the maximum time duration that can be set is limited to
> ~2.147 seconds. Change their definitions to u64 in the structs of the
> PWM framework so that higher durations may be set.
>
> Also use the right format specifiers in debug prints in both core.c as
> well as pwm-stm32-lp.c.
>
> Cc: Fabrice Gasnier <fabrice.gasnier@st.com>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: Alexandre Torgue <alexandre.torgue@st.com>
> Cc: Joe Perches <joe@perches.com>
>
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Guru Das Srinagesh <gurus@codeaurora.org>
I like this change in general. I didn't check all the prepatory patches
in detail but the few I glanced over looked ok.
I think we have to prepare for having to fix a few fallouts but consider
it ok to expose this in next (but wouldn't send it for 5.8-rc1 yet).
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
next prev parent reply other threads:[~2020-05-22 13:26 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1587523702.git.gurus@codeaurora.org>
2020-04-22 2:57 ` [PATCH v13 01/11] drm/i915: Use 64-bit division macro Guru Das Srinagesh
2020-04-24 6:17 ` Jani Nikula
2020-04-24 22:17 ` Guru Das Srinagesh
2020-04-27 13:48 ` Jani Nikula
2020-04-22 2:57 ` [PATCH v13 02/11] hwmon: pwm-fan: " Guru Das Srinagesh
2020-04-22 2:57 ` [PATCH v13 03/11] ir-rx51: " Guru Das Srinagesh
2020-04-22 2:57 ` [PATCH v13 04/11] pwm: clps711x: Cast period to u32 before use as divisor Guru Das Srinagesh
2020-04-23 9:30 ` Geert Uytterhoeven
2020-04-24 22:21 ` Guru Das Srinagesh
2020-04-22 2:57 ` [PATCH v13 05/11] pwm: pwm-imx-tpm: Use 64-bit division macro Guru Das Srinagesh
2020-04-22 2:57 ` [PATCH v13 06/11] pwm: imx27: Use 64-bit division macro and function Guru Das Srinagesh
2020-04-22 2:57 ` [PATCH v13 07/11] pwm: sifive: Use 64-bit division macro Guru Das Srinagesh
2020-04-22 2:57 ` [PATCH v13 08/11] pwm: sun4i: Use nsecs_to_jiffies to avoid a division Guru Das Srinagesh
2020-04-22 2:57 ` [PATCH v13 09/11] backlight: pwm_bl: Use 64-bit division function Guru Das Srinagesh
2020-05-26 7:00 ` Lee Jones
2020-04-22 2:57 ` [PATCH v13 10/11] clk: pwm: " Guru Das Srinagesh
2020-04-22 2:57 ` [PATCH v13 11/11] pwm: core: Convert period and duty cycle to u64 Guru Das Srinagesh
2020-05-22 13:26 ` Uwe Kleine-König [this message]
[not found] ` <20200423114857.GG3612@dell>
[not found] ` <20200423215306.GA8670@codeaurora.org>
[not found] ` <20200424064303.GJ3612@dell>
[not found] ` <20200424221422.GA31118@codeaurora.org>
[not found] ` <20200427064434.GA3559@dell>
2020-05-20 23:15 ` [PATCH v13 00/11] Convert PWM " Guru Das Srinagesh
2020-05-21 7:15 ` Lee Jones
2020-05-22 11:16 ` Thierry Reding
2020-05-22 11:31 ` Lee Jones
2020-05-22 12:50 ` Thierry Reding
2020-05-22 22:59 ` Guru Das Srinagesh
2020-05-26 6:59 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200522132631.sazoyq2d3krdvg6o@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=alexandre.torgue@st.com \
--cc=collinsd@codeaurora.org \
--cc=fabrice.gasnier@st.com \
--cc=gurus@codeaurora.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=subbaram@codeaurora.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).