linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: Michal Simek <michal.simek@xilinx.com>
Cc: Dejin Zheng <zhengdejin5@gmail.com>,
	harinik@xilinx.com, soren.brinkmann@xilinx.com,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] i2c: cadence: Add an error handling for platform_get_irq()
Date: Fri, 22 May 2020 17:14:59 +0200	[thread overview]
Message-ID: <20200522151459.GK5670@ninjato> (raw)
In-Reply-To: <2d99f043-f854-8975-86ee-2f0ba1382275@xilinx.com>

[-- Attachment #1: Type: text/plain, Size: 486 bytes --]


> The change is valid but the question is if make sense to do it in this
> way. Some drivers are using devm_request_irq to do do job.
> 
> For example:
>  	id->irq = platform_get_irq(pdev, 0);
>         ret = devm_request_irq(&pdev->dev, id->irq, cdns_i2c_isr, 0,
>                                   DRIVER_NAME, id);
>         if (ret)
> 		return ret;

I like this version better. Maybe we should simply move the
platform_get_irq() line to the devm_request_irq() call?


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2020-05-22 15:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-20 14:48 [PATCH v2] i2c: cadence: Add an error handling for platform_get_irq() Dejin Zheng
2020-05-22 11:24 ` Michal Simek
2020-05-22 15:14   ` Wolfram Sang [this message]
2020-05-22 15:26     ` Michal Simek
2020-05-22 20:19       ` Wolfram Sang
2020-05-23 13:36         ` Dejin Zheng
2020-05-23 15:26   ` Dejin Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200522151459.GK5670@ninjato \
    --to=wsa@the-dreams.de \
    --cc=harinik@xilinx.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=soren.brinkmann@xilinx.com \
    --cc=zhengdejin5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).