LKML Archive on
 help / color / Atom feed
From: Oscar Carter <>
To: Takashi Sakamoto <>
Cc: Oscar Carter <>,
	Kees Cook <>,
	Stefan Richter <>,
	Mauro Carvalho Chehab <>,
	Clemens Ladisch <>,
	Jaroslav Kysela <>, Takashi Iwai <>,,,,,,
	"Lev R . Oshvang ." <>
Subject: Re: [PATCH v2] firewire: Remove function callback casts
Date: Fri, 22 May 2020 19:43:08 +0200
Message-ID: <20200522174308.GB3059@ubuntu> (raw)
In-Reply-To: <20200520061624.GA25690@workstation>


On Wed, May 20, 2020 at 03:16:24PM +0900, Takashi Sakamoto wrote:
> Hi,
> I'm an author of ALSA firewire stack and thanks for the patch. I agree with
> your intention to remove the cast of function callback toward CFI build.
> Practically, the isochronous context with FW_ISO_CONTEXT_RECEIVE_MULTICHANNEL
> is never used by in-kernel drivers. Here, I propose to leave current
> kernel API (fw_iso_context_create() with fw_iso_callback_t) as is.
> Alternatively, a new kernel API for the context (e.g.
> fw_iso_mc_context_create() with fw_iso_mc_callback_t). This idea leaves
> current drivers as is and the change is done inner firewire-core driver,
> therefore existent kernel API is not changed.
It sounds good to me.

> Later I post two patches for the proposal. I'd like you to review it and
> I'm glad to receive your comments.
I will take a look at your proposal. Thanks for your time and work.
> Regards
> Takashi Sakamoto

Oscar Carter

  reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-19 17:34 Oscar Carter
2020-05-20  6:16 ` Takashi Sakamoto
2020-05-22 17:43   ` Oscar Carter [this message]
2020-05-23  6:10     ` greg
2020-05-23  6:10     ` Greg KH
2020-05-23  7:58       ` Takashi Sakamoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200522174308.GB3059@ubuntu \ \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on

Archives are clonable:
	git clone --mirror lkml/git/0.git
	git clone --mirror lkml/git/1.git
	git clone --mirror lkml/git/2.git
	git clone --mirror lkml/git/3.git
	git clone --mirror lkml/git/4.git
	git clone --mirror lkml/git/5.git
	git clone --mirror lkml/git/6.git
	git clone --mirror lkml/git/7.git
	git clone --mirror lkml/git/8.git
	git clone --mirror lkml/git/9.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ \
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone