From: Sudeep Holla <sudeep.holla@arm.com>
To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: Sudeep Holla <sudeep.holla@arm.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Tony Lindgren <tony@atomide.com>,
linux-omap@vger.kernel.org
Subject: [PATCH 7/8] ARM: OMAP2: Switch to use DEVICE_ATTR_RO()
Date: Sat, 23 May 2020 18:08:58 +0100 [thread overview]
Message-ID: <20200523170859.50003-8-sudeep.holla@arm.com> (raw)
In-Reply-To: <20200523170859.50003-1-sudeep.holla@arm.com>
Move device attributes to DEVICE_ATTR_RO() as that would make things
a lot more "obvious" what is happening over the existing __ATTR usage.
Cc: Tony Lindgren <tony@atomide.com>
Cc: linux-omap@vger.kernel.org
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
arch/arm/mach-omap2/id.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c
index 188ea5258c99..37ac2d103548 100644
--- a/arch/arm/mach-omap2/id.c
+++ b/arch/arm/mach-omap2/id.c
@@ -775,15 +775,13 @@ static const char * __init omap_get_family(void)
return kasprintf(GFP_KERNEL, "Unknown");
}
-static ssize_t omap_get_type(struct device *dev,
- struct device_attribute *attr,
- char *buf)
+static ssize_t
+type_show(struct device *dev, struct device_attribute *attr, char *buf)
{
return sprintf(buf, "%s\n", omap_types[omap_type()]);
}
-static struct device_attribute omap_soc_attr =
- __ATTR(type, S_IRUGO, omap_get_type, NULL);
+static DEVICE_ATTR_RO(type);
void __init omap_soc_device_init(void)
{
@@ -806,6 +804,6 @@ void __init omap_soc_device_init(void)
}
parent = soc_device_to_device(soc_dev);
- device_create_file(parent, &omap_soc_attr);
+ device_create_file(parent, &dev_attr_type);
}
#endif /* CONFIG_SOC_BUS */
--
2.17.1
next prev parent reply other threads:[~2020-05-23 17:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-23 17:08 [PATCH 0/8] soc: Use custom soc attribute group and DEVICE_ATTR_RO Sudeep Holla
2020-05-23 17:08 ` [PATCH 1/8] soc: realview: Switch to use DEVICE_ATTR_RO() Sudeep Holla
2020-05-25 11:44 ` Linus Walleij
2020-05-23 17:08 ` [PATCH 2/8] soc: realview: Use custom soc attribute group instead of device_create_file Sudeep Holla
2020-05-25 11:45 ` Linus Walleij
2020-05-23 17:08 ` [PATCH 3/8] soc: integrator: Switch to use DEVICE_ATTR_RO() Sudeep Holla
2020-05-25 11:45 ` Linus Walleij
2020-05-23 17:08 ` [PATCH 4/8] soc: integrator: Use custom soc attribute group instead of device_create_file Sudeep Holla
2020-05-25 11:46 ` Linus Walleij
2020-05-23 17:08 ` [PATCH 5/8] soc: ux500: Switch to use DEVICE_ATTR_RO() Sudeep Holla
2020-05-25 11:46 ` Linus Walleij
2020-05-23 17:08 ` [PATCH 6/8] soc: ux500: Use custom soc attribute group instead of device_create_file Sudeep Holla
2020-05-25 11:46 ` Linus Walleij
2020-05-23 17:08 ` Sudeep Holla [this message]
2020-05-29 17:47 ` [PATCH 7/8] ARM: OMAP2: Switch to use DEVICE_ATTR_RO() Tony Lindgren
2020-05-23 17:08 ` [PATCH 8/8] ARM: OMAP2: Use custom soc attribute group instead of device_create_file Sudeep Holla
2020-05-29 18:01 ` Tony Lindgren
2020-05-27 9:03 ` [PATCH 0/8] soc: Use custom soc attribute group and DEVICE_ATTR_RO Greg Kroah-Hartman
2020-05-27 16:52 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200523170859.50003-8-sudeep.holla@arm.com \
--to=sudeep.holla@arm.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).