From: wu000273@umn.edu
To: sylvester.nawrocki@gmail.com
Cc: mchehab@kernel.org, linux-media@vger.kernel.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
kjlu@umn.edu, wu000273@umn.edu
Subject: [PATCH V2] media: s3c-camif: fix missing disable in tegra_adma_probe().
Date: Sat, 23 May 2020 22:46:16 -0500 [thread overview]
Message-ID: <20200524034616.31625-1-wu000273@umn.edu> (raw)
From: Qiushi Wu <wu000273@umn.edu>
"pm_runtime_enable()" was not handled by "pm_runtime_disable()"
after a call of the function “pm_runtime_get_sync()” failed.
Thus move the jump target “err_pm” before calling function
"calling pm_runtime_disable()".
Fixes: babde1c243b2 ("[media] V4L: Add driver for S3C24XX/S3C64XX SoC series camera interface")
Signed-off-by: Qiushi Wu <wu000273@umn.edu>
---
V2: improving commit messages.
---
drivers/media/platform/s3c-camif/camif-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/s3c-camif/camif-core.c b/drivers/media/platform/s3c-camif/camif-core.c
index c6fbcd7036d6..12ee49638f44 100644
--- a/drivers/media/platform/s3c-camif/camif-core.c
+++ b/drivers/media/platform/s3c-camif/camif-core.c
@@ -500,8 +500,8 @@ static int s3c_camif_probe(struct platform_device *pdev)
camif_unregister_media_entities(camif);
err_alloc:
pm_runtime_put(dev);
- pm_runtime_disable(dev);
err_pm:
+ pm_runtime_disable(dev);
camif_clk_put(camif);
err_clk:
s3c_camif_unregister_subdev(camif);
--
2.17.1
next reply other threads:[~2020-05-24 3:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-24 3:46 wu000273 [this message]
2020-05-24 19:03 ` [PATCH V2] media: s3c-camif: fix missing disable in tegra_adma_probe() Sylwester Nawrocki
2020-05-24 19:27 ` Sylwester Nawrocki
2020-05-24 9:03 [PATCH v2] media: s3c-camif: Fix " Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200524034616.31625-1-wu000273@umn.edu \
--to=wu000273@umn.edu \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sylvester.nawrocki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).