From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC4EFC433E0 for ; Sun, 24 May 2020 21:12:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 897EC2078B for ; Sun, 24 May 2020 21:12:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590354746; bh=Flr026ZtzINe0Q7Gpmgcr+VZp7b/m6owt3uG5bFsaQw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=K5n1XDbJSoMBcsfe/o9o2M4SQCTiv+sKXVA4hsUHGtI+PHxgRktqSW71hx+btIyaX zCiC9PJYeGu/VWiM6JTCajnEbkMa1iNlS/gSVUZeJksCuI1EXjb2KBfffbmuLq2Jwb GNxJYiKG/erh2zmqYlq3FtJXKO/gej2NwqSLrGs4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388116AbgEXVMY (ORCPT ); Sun, 24 May 2020 17:12:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:49014 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387830AbgEXVMX (ORCPT ); Sun, 24 May 2020 17:12:23 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BAE4E2076C; Sun, 24 May 2020 21:12:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590354743; bh=Flr026ZtzINe0Q7Gpmgcr+VZp7b/m6owt3uG5bFsaQw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=V5EE6nGn1WgxJLQFbmLcD7DFe8/QvumGgHGpS+WC1MnwGJyRqfFE6hOLPxlS+K6oy Ae4BaEvjSh6Wk/IhmDstdeRQ+6L0fb2l4HwRqIC8pjtLi6KlRwsXj0/8ucNM9HrHDb dT5Af3/4Gz/PVwPWKizy/8TlGcYO7WTIoF9zWZm8= Date: Sun, 24 May 2020 17:12:21 -0400 From: Sasha Levin To: Linus Torvalds Cc: Greg KH , Heikki Krogerus , Andrew Morton , Linux Kernel Mailing List , Stephen Rothwell Subject: Re: [GIT PULL] Driver core fixes for 5.7-rc7 - take 2 Message-ID: <20200524211221.GW33628@sasha-vm> References: <20200523131759.GA55886@kroah.com> <20200523152922.GA224858@kroah.com> <20200524150018.GB11262@kroah.com> <20200524194550.GV33628@sasha-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200524194550.GV33628@sasha-vm> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 24, 2020 at 03:45:50PM -0400, Sasha Levin wrote: >On Sun, May 24, 2020 at 10:05:28AM -0700, Linus Torvalds wrote: >>Sasha mentioned "--follow", which also happens to show that commit, >>but that's more of an incidental happenstance than anything else. "git >>log --follow" is kind of a special case, where git stops doing some of >>the pathname-based simplifying, because if the file shows up from >>nothing, git will try to then figure out where it came from. The fact >>that "--follow" this ends up not pruning irrelevant history as >>aggressively is more of an implementation artifact than anything else. >> >>So generally, don't use "--follow". It's kind of a hack to emulate >>"track changes to a file", but it is a hack, and it fundamentally is a >>bogus operation (for all the same reasons that the CVS/SCCS/SVN/etc >>notion of a "file identity" is complete garbage and leads to >>fundamental problems). > >Interesting. My thinking around --follow was that it's like >--full-history in the sense that it won't prune history, but it would >also keep listing history beyond file renames. > >The --follow functionality is quite useful when looking at older >branches and trying to understand where changes should go into on those >older branches. > >We also do have some notion of "file identity" in the kernel; it's >prevalent with "quirk files". Look at these for example: > > - drivers/mmc/core/quirks.h > - sound/pci/hda/patch_*.c > - drivers/hid/hid-quirks.c > >We know that patches to those files are likely to contain quirks (which >we usually want to take into the Stable branches) so I might have a >script that monitors a list of these "special" files in which case I >need to see a complete list of commits that went into those files. (and I'd like to see the reverts too, so that I could apply that revert to Stable trees as well. If a revert doesn't show up in git log we might miss doing a backport of it). -- Thanks, Sasha