From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8DD2C433DF for ; Mon, 25 May 2020 08:47:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7AFAB206DD for ; Mon, 25 May 2020 08:47:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="e3h7fzrT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389241AbgEYIr1 (ORCPT ); Mon, 25 May 2020 04:47:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388891AbgEYIr1 (ORCPT ); Mon, 25 May 2020 04:47:27 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB997C061A0E; Mon, 25 May 2020 01:47:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=aEAVGocE9wZ3VarXBFE8qCciH8rwdSc1/pmEy3uHC80=; b=e3h7fzrT5Xm6knH2AwC0CixG6 evgVpOCBUDtRLhr06qYru8M/o/tRuRpKzEs36RXfa3bT0u9UdLDEP+vERCwUbAW30jf+WUFw13SiD nBuDlJzQAG4HYezjiKbDFjsBmkduFWEZxdZ3dAUEDP6StNwcs5M7CTpJRtQSdod4fiWVvbHKmel2J k1K5vEmHvXNTxKiO0FrvsL4Gnn75dlX6EXTsT10197jJV5WuZU4etJ9Rm0YDYAvq9HV+rnU0aJ3wl fI7ckARX7ZG2PKbA30oQQ1UvU4mvD0TG3viToWCSO4v6FQwnbIilQtg17tHN0L65PTAKDuJi5K7Et CksZ4dLNg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:36714) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jd8lU-0004kc-Qc; Mon, 25 May 2020 09:47:20 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1jd8lT-0004Do-4u; Mon, 25 May 2020 09:47:19 +0100 Date: Mon, 25 May 2020 09:47:19 +0100 From: Russell King - ARM Linux admin To: Nicolas Ferre Cc: Jakub Kicinski , netdev@vger.kernel.org, "David S. Miller" , f.fainelli@gmail.com, Alexandre Belloni , antoine.tenart@bootlin.com, linux-kernel@vger.kernel.org, harini.katakam@xilinx.com, Claudiu Beznea , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 1/5] net: macb: fix wakeup test in runtime suspend/resume routines Message-ID: <20200525084719.GJ1551@shell.armlinux.org.uk> References: <20200506131843.22cf1dab@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <347c9a4f-8a01-a931-c9d5-536339337f8a@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 25, 2020 at 10:18:16AM +0200, Nicolas Ferre wrote: > On 07/05/2020 at 12:03, Nicolas Ferre wrote: > > On 06/05/2020 at 22:18, Jakub Kicinski wrote: > > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > > > > > On Wed, 6 May 2020 13:37:37 +0200 nicolas.ferre@microchip.com wrote: > > > > From: Nicolas Ferre > > > > > > > > Use the proper struct device pointer to check if the wakeup flag > > > > and wakeup source are positioned. > > > > Use the one passed by function call which is equivalent to > > > > &bp->dev->dev.parent. > > > > > > > > It's preventing the trigger of a spurious interrupt in case the > > > > Wake-on-Lan feature is used. > > > > > > > > Fixes: bc1109d04c39 ("net: macb: Add pm runtime support") > > > > > > Fixes tag: Fixes: bc1109d04c39 ("net: macb: Add pm runtime support") > > > Has these problem(s): > > > - Target SHA1 does not exist > > > > Indeed, it's: > > Fixes: d54f89af6cc4 ("net: macb: Add pm runtime support") > > > > David: do I have to respin or you can modify it? > > David, all, I'm about to resend this series (alternative to "ping"), > however: > > 1/ Now that it's late in the cycle, I'd like that you tell me if I rebase on > net-next because it isn't not sensible to queue such (non urgeent) changes > at rc7 > > 2/ I didn't get answers from Russell and can't tell if there's a better way > of handling underlying phylink error of phylink_ethtool_set_wol() in patch > 3/5 I think you could have answered your own questions there, but I seemed easier to send an email. I've just read the code, typed out an appropriate description of the code's behaviour, and then derived the answer to your questions without anything else. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC for 0.8m (est. 1762m) line in suburbia: sync at 13.1Mbps down 424kbps up