From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CECCC433DF for ; Mon, 25 May 2020 19:38:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 520362068D for ; Mon, 25 May 2020 19:38:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gAzF6pZP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390245AbgEYTiJ (ORCPT ); Mon, 25 May 2020 15:38:09 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:53591 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2389904AbgEYThz (ORCPT ); Mon, 25 May 2020 15:37:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590435473; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gAE7iYHh0lMWxsQHsKFyB4beKvHZhlL9u5WlD2TFpMQ=; b=gAzF6pZPJPQ7KbJxuyeG6Tk6deayXoWEHziCMe3R7PYSg79y2hV+VtQ8Xd7RIaojyAYEyb EADUjSZoypmMHHvCFZXH4HYWZaSexOU6RLsO3OJJ54+V41LHrV2Y21xZwiSrklUfMAy0tE QDlIxrRT7FDCPp0I5kC7sySYm/TGUt4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-388-5A4oE3PUML-P6-CwQP3b6g-1; Mon, 25 May 2020 15:37:51 -0400 X-MC-Unique: 5A4oE3PUML-P6-CwQP3b6g-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9E9868018A3; Mon, 25 May 2020 19:37:50 +0000 (UTC) Received: from fuller.cnet (ovpn-116-16.gru2.redhat.com [10.97.116.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 330146EDB1; Mon, 25 May 2020 19:37:50 +0000 (UTC) Received: by fuller.cnet (Postfix, from userid 1000) id 1E487416CE4C; Mon, 25 May 2020 16:23:55 -0300 (-03) Date: Mon, 25 May 2020 16:23:55 -0300 From: Marcelo Tosatti To: Xu Yilun Cc: mdf@kernel.org, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, trix@redhat.com, bhu@redhat.com, Luwei Kang , Wu Hao Subject: Re: [PATCH v5 4/7] fpga: dfl: afu: add interrupt support for port error reporting Message-ID: <20200525192355.GD22266@fuller.cnet> References: <1587370303-25568-1-git-send-email-yilun.xu@intel.com> <1587370303-25568-5-git-send-email-yilun.xu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1587370303-25568-5-git-send-email-yilun.xu@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 20, 2020 at 04:11:40PM +0800, Xu Yilun wrote: > Error reporting interrupt is very useful to notify users that some > errors are detected by the hardware. Once users are notified, they > could query hardware logged error states, no need to continuously > poll on these states. > > This patch adds interrupt support for port error reporting sub feature. > It follows the common DFL interrupt notification and handling mechanism, > implements two ioctl commands below for user to query number of irqs > supported, and set/unset interrupt triggers. > > Ioctls: > * DFL_FPGA_PORT_ERR_GET_IRQ_NUM > get the number of irqs, which is used to determine whether/how many > interrupts error reporting feature supports. > > * DFL_FPGA_PORT_ERR_SET_IRQ > set/unset given eventfds as error interrupt triggers. > > Signed-off-by: Luwei Kang > Signed-off-by: Wu Hao > Signed-off-by: Xu Yilun > Acked-by: Wu Hao > ---- > v2: use DFL_FPGA_PORT_ERR_GET_IRQ_NUM instead of > DFL_FPGA_PORT_ERR_GET_INFO > Delete flag field for DFL_FPGA_PORT_ERR_SET_IRQ param > v3: put_user() instead of copy_to_user() > improves comments > v4: use common functions to handle irq ioctls > v5: minor fixes for Hao's comments > --- > drivers/fpga/dfl-afu-error.c | 17 +++++++++++++++++ > drivers/fpga/dfl-afu-main.c | 4 ++++ > include/uapi/linux/fpga-dfl.h | 23 +++++++++++++++++++++++ > 3 files changed, 44 insertions(+) > > diff --git a/drivers/fpga/dfl-afu-error.c b/drivers/fpga/dfl-afu-error.c > index c1467ae..c469118 100644 > --- a/drivers/fpga/dfl-afu-error.c > +++ b/drivers/fpga/dfl-afu-error.c > @@ -14,6 +14,7 @@ > * Mitchel Henry > */ > > +#include > #include > > #include "dfl-afu.h" > @@ -219,6 +220,21 @@ static void port_err_uinit(struct platform_device *pdev, > afu_port_err_mask(&pdev->dev, true); > } > > +static long > +port_err_ioctl(struct platform_device *pdev, struct dfl_feature *feature, > + unsigned int cmd, unsigned long arg) > +{ > + switch (cmd) { > + case DFL_FPGA_PORT_ERR_GET_IRQ_NUM: > + return dfl_feature_ioctl_get_num_irqs(pdev, feature, arg); > + case DFL_FPGA_PORT_ERR_SET_IRQ: > + return dfl_feature_ioctl_set_irq(pdev, feature, arg); > + default: > + dev_dbg(&pdev->dev, "%x cmd not handled", cmd); > + return -ENODEV; > + } > +} > + > const struct dfl_feature_id port_err_id_table[] = { > {.id = PORT_FEATURE_ID_ERROR,}, > {0,} > @@ -227,4 +243,5 @@ const struct dfl_feature_id port_err_id_table[] = { > const struct dfl_feature_ops port_err_ops = { > .init = port_err_init, > .uinit = port_err_uinit, > + .ioctl = port_err_ioctl, > }; > diff --git a/drivers/fpga/dfl-afu-main.c b/drivers/fpga/dfl-afu-main.c > index 3fa2c59..b1ed7b4 100644 > --- a/drivers/fpga/dfl-afu-main.c > +++ b/drivers/fpga/dfl-afu-main.c > @@ -578,6 +578,7 @@ static int afu_release(struct inode *inode, struct file *filp) > { > struct platform_device *pdev = filp->private_data; > struct dfl_feature_platform_data *pdata; > + struct dfl_feature *feature; > > dev_dbg(&pdev->dev, "Device File Release\n"); > > @@ -587,6 +588,9 @@ static int afu_release(struct inode *inode, struct file *filp) > dfl_feature_dev_use_end(pdata); > > if (!dfl_feature_dev_use_count(pdata)) { > + dfl_fpga_dev_for_each_feature(pdata, feature) > + dfl_fpga_set_irq_triggers(feature, 0, > + feature->nr_irqs, NULL); > __port_reset(pdev); > afu_dma_region_destroy(pdata); > } > diff --git a/include/uapi/linux/fpga-dfl.h b/include/uapi/linux/fpga-dfl.h > index 7331350..6c71c9d 100644 > --- a/include/uapi/linux/fpga-dfl.h > +++ b/include/uapi/linux/fpga-dfl.h > @@ -164,6 +164,29 @@ struct dfl_fpga_irq_set { > __s32 evtfds[]; > }; > > +/** > + * DFL_FPGA_PORT_ERR_GET_IRQ_NUM - _IOR(DFL_FPGA_MAGIC, DFL_PORT_BASE + 5, > + * __u32 num_irqs) > + * > + * Get the number of irqs supported by the fpga port error reporting private > + * feature. Currently hardware supports up to 1 irq. > + * Return: 0 on success, -errno on failure. > + */ > +#define DFL_FPGA_PORT_ERR_GET_IRQ_NUM _IOR(DFL_FPGA_MAGIC, \ > + DFL_PORT_BASE + 5, __u32) > + > +/** > + * DFL_FPGA_PORT_ERR_SET_IRQ - _IOW(DFL_FPGA_MAGIC, DFL_PORT_BASE + 6, > + * struct dfl_fpga_irq_set) > + * > + * Set fpga port error reporting interrupt trigger if evtfds[n] is valid. > + * Unset related interrupt trigger if evtfds[n] is a negative value. > + * Return: 0 on success, -errno on failure. > + */ > +#define DFL_FPGA_PORT_ERR_SET_IRQ _IOW(DFL_FPGA_MAGIC, \ > + DFL_PORT_BASE + 6, \ > + struct dfl_fpga_irq_set) > + > /* IOCTLs for FME file descriptor */ > > /** > -- > 2.7.4 Reviewed-by: Marcelo Tosatti