From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E24B8C433E0 for ; Tue, 26 May 2020 06:46:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6752F207CB for ; Tue, 26 May 2020 06:46:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="cRxQJrFo"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="wKA3jowS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730107AbgEZGqH (ORCPT ); Tue, 26 May 2020 02:46:07 -0400 Received: from wnew1-smtp.messagingengine.com ([64.147.123.26]:38203 "EHLO wnew1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725783AbgEZGqH (ORCPT ); Tue, 26 May 2020 02:46:07 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.west.internal (Postfix) with ESMTP id 23110972; Tue, 26 May 2020 02:46:05 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 26 May 2020 02:46:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=5RYRLhyLsMnW5/cobsL2Hqy7R67 BSPcGYQeOH6J+GMs=; b=cRxQJrFoaymwwcyEAfUp0pX8PLnfnsJ5xPQgBcnSMoc j1JKjHjJKGGR1U/tgoRcISR85Hgz5h1YqFMKqn/gnU67SKST1jhvUvCI3rHeot8V rpQ9k8BWRTP0qWcJlRlD8UwZvP8fxJEs9aNiQYsOBN3TSphjKcCRrIBGSpv5ZF14 IN4wI8VgF1ZxKsLsno7FswJzL0FP+u2yfGhNcKymfHmmYx1wQiCJMdKzzLHn/7ua uyr5sTlfKBe7gXAOhEvU+yb1S+KMgl3spboyFzLcEtgAuPOZEzo3Om/cJDWiMjaD 55E4UFOGIYaDV3xbMG0SshjuwP1UI5n2tHdRlsjijRg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=5RYRLh yLsMnW5/cobsL2Hqy7R67BSPcGYQeOH6J+GMs=; b=wKA3jowSlyXRdNPIOtvTwO 0jn4TPD61XyP6+PzPK9yAA9SZlEu4V80tbqI/dU5cXKAmlSPSzGf+8xRXeVEmxjH RsHWwllbqfOrThRITPR10RpxK/JqpnUx0RAfLFAjNjgpa8n0xQNkwLnTSMy8WAq8 t5kWnGv4O+h4iEECMifmwcpclAEaQmW0CT7gd2grLwGzQcXMLcslif7sHFpf59Jh FxyS83zrgmZkGzHSKHipn151m3bM+TW+n4fdouGLXNEe1vSyuX1e47FmAxczGJZY TsLuuRTjZt0Jo15I/9NCTDNIdGx4f7eABGVC/VzKJpTChghYkGMbzEEzsv5e8j7w == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedruddvuddguddtkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepifhrvghg ucfmjfcuoehgrhgvgheskhhrohgrhhdrtghomheqnecuggftrfgrthhtvghrnhepveeuhe ejgfffgfeivddukedvkedtleelleeghfeljeeiueeggeevueduudekvdetnecukfhppeek fedrkeeirdekledruddtjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmh grihhlfhhrohhmpehgrhgvgheskhhrohgrhhdrtghomh X-ME-Proxy: Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) by mail.messagingengine.com (Postfix) with ESMTPA id EEEA93280065; Tue, 26 May 2020 02:46:03 -0400 (EDT) Date: Tue, 26 May 2020 08:46:01 +0200 From: Greg KH To: Andra Paraschiv Cc: linux-kernel@vger.kernel.org, Anthony Liguori , Benjamin Herrenschmidt , Colm MacCarthaigh , Bjoern Doebel , David Woodhouse , Frank van der Linden , Alexander Graf , Martin Pohlack , Matt Wilson , Paolo Bonzini , Balbir Singh , Stefano Garzarella , Stefan Hajnoczi , Stewart Smith , Uwe Dannowski , kvm@vger.kernel.org, ne-devel-upstream@amazon.com Subject: Re: [PATCH v3 03/18] nitro_enclaves: Define enclave info for internal bookkeeping Message-ID: <20200526064601.GB2580530@kroah.com> References: <20200525221334.62966-1-andraprs@amazon.com> <20200525221334.62966-4-andraprs@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200525221334.62966-4-andraprs@amazon.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 26, 2020 at 01:13:19AM +0300, Andra Paraschiv wrote: > +/* Nitro Enclaves (NE) misc device */ > +extern struct miscdevice ne_miscdevice; Why does your misc device need to be in a .h file? Having the patch series like this (add random .h files, and then start to use them), is hard to review. Would you want to try to review a series written in this way? thanks, greg k-h