From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A585DC433DF for ; Tue, 26 May 2020 10:10:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7EA812073B for ; Tue, 26 May 2020 10:10:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731881AbgEZKK1 (ORCPT ); Tue, 26 May 2020 06:10:27 -0400 Received: from foss.arm.com ([217.140.110.172]:48548 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731716AbgEZKK1 (ORCPT ); Tue, 26 May 2020 06:10:27 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7F6941FB; Tue, 26 May 2020 03:10:26 -0700 (PDT) Received: from bogus (unknown [10.37.8.209]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 56E413F52E; Tue, 26 May 2020 03:10:22 -0700 (PDT) Date: Tue, 26 May 2020 11:10:19 +0100 From: Sudeep Holla To: Jianyong Wu Cc: "netdev@vger.kernel.org" , "yangbo.lu@nxp.com" , "john.stultz@linaro.org" , "tglx@linutronix.de" , "pbonzini@redhat.com" , "sean.j.christopherson@intel.com" , "maz@kernel.org" , "richardcochran@gmail.com" , Mark Rutland , "will@kernel.org" , Suzuki Poulose , Steven Price , Justin He , Wei Chen , "kvm@vger.kernel.org" , Steve Capper , "linux-kernel@vger.kernel.org" , Kaly Xin , nd , Sudeep Holla , "kvmarm@lists.cs.columbia.edu" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [RFC PATCH v12 03/11] psci: export smccc conduit get helper. Message-ID: <20200526101019.GB11414@bogus> References: <20200522083724.38182-1-jianyong.wu@arm.com> <20200522083724.38182-4-jianyong.wu@arm.com> <20200522131206.GA15171@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 25, 2020 at 01:37:56AM +0000, Jianyong Wu wrote: > Hi Sudeep, > > > -----Original Message----- > > From: Sudeep Holla > > Sent: Friday, May 22, 2020 9:12 PM > > To: Jianyong Wu > > Cc: netdev@vger.kernel.org; yangbo.lu@nxp.com; john.stultz@linaro.org; > > tglx@linutronix.de; pbonzini@redhat.com; sean.j.christopherson@intel.com; > > maz@kernel.org; richardcochran@gmail.com; Mark Rutland > > ; will@kernel.org; Suzuki Poulose > > ; Steven Price ; Justin > > He ; Wei Chen ; > > kvm@vger.kernel.org; Steve Capper ; linux- > > kernel@vger.kernel.org; Kaly Xin ; nd ; > > Sudeep Holla ; kvmarm@lists.cs.columbia.edu; > > linux-arm-kernel@lists.infradead.org > > Subject: Re: [RFC PATCH v12 03/11] psci: export smccc conduit get helper. > > > > On Fri, May 22, 2020 at 04:37:16PM +0800, Jianyong Wu wrote: > > > Export arm_smccc_1_1_get_conduit then modules can use smccc helper > > > which adopts it. > > > > > > Acked-by: Mark Rutland > > > Signed-off-by: Jianyong Wu > > > --- > > > drivers/firmware/psci/psci.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/firmware/psci/psci.c > > > b/drivers/firmware/psci/psci.c index 2937d44b5df4..fd3c88f21b6a 100644 > > > --- a/drivers/firmware/psci/psci.c > > > +++ b/drivers/firmware/psci/psci.c > > > @@ -64,6 +64,7 @@ enum arm_smccc_conduit > > > arm_smccc_1_1_get_conduit(void) > > > > > > return psci_ops.conduit; > > > } > > > +EXPORT_SYMBOL(arm_smccc_1_1_get_conduit); > > > > > > > I have moved this into drivers/firmware/smccc/smccc.c [1] Please update > > this accordingly. > > Ok, I will remove this patch next version. You may need it still, just that this patch won't apply as the function is moved to a new file. -- Regards, Sudeep