From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A90DC433DF for ; Tue, 26 May 2020 18:33:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DA203206F1 for ; Tue, 26 May 2020 18:33:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590517992; bh=zqqKYGDqYq+jWP/jsl64bWcD9Pu4bJsseF9495JaNws=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=UgcoWbpAYBVAZsey9R1VSFNANiZAZUI9eEpXC0j+wIAVPD3aQymf1yhSXJQX60oID ulCwh16SMjH+bKeyY72z19yWW+K22EsolNJuTVkV09O0qKe3B5Ylkt4hQovBXg4Uxh hGMOq8yHifUKZ7p0j0I5aa0aEUvAdrF/Z9b1xn5Q= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730209AbgEZSdM (ORCPT ); Tue, 26 May 2020 14:33:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:39668 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728113AbgEZSdL (ORCPT ); Tue, 26 May 2020 14:33:11 -0400 Received: from kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net (unknown [163.114.132.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 919F72068D; Tue, 26 May 2020 18:33:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590517991; bh=zqqKYGDqYq+jWP/jsl64bWcD9Pu4bJsseF9495JaNws=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=xoKoTwDBiy/RtF4geXCUT9O945JVCDIyVCuaAHHe/qgGUoSZxbRMT8nvmG0FfT7t1 OkkLZoLpkyFRoImhyuBgbQ+iIOnvHNyanKx9oppQJljEQ4c3Hz99pda6K1cI4MsypW VS+ABpkVNrs7NQ3kBwrCqLL2vkSrVB88TiRRb/kE= Date: Tue, 26 May 2020 11:33:09 -0700 From: Jakub Kicinski To: Vadym Kochan Cc: "David S. Miller" , Jiri Pirko , Ido Schimmel , Andrew Lunn , Oleksandr Mazur , Serhiy Boiko , Serhiy Pshyk , Volodymyr Mytnyk , Taras Chornyi , Andrii Savka , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Mickey Rachamim Subject: Re: [net-next RFC v3 2/6] net: marvell: prestera: Add PCI interface support Message-ID: <20200526113309.1c46d496@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> In-Reply-To: <20200526171302.28649-3-vadym.kochan@plvision.eu> References: <20200526171302.28649-1-vadym.kochan@plvision.eu> <20200526171302.28649-3-vadym.kochan@plvision.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 26 May 2020 20:12:58 +0300 Vadym Kochan wrote: > Add PCI interface driver for Prestera Switch ASICs family devices, which > provides: > > - Firmware loading mechanism > - Requests & events handling to/from the firmware > - Access to the firmware on the bus level > > The firmware has to be loaded each time device is reset. The driver is > loading it from: > > /lib/firmware/marvell/prestera_fw-v{MAJOR}.{MINOR}.img > > The full firmware image version is located within internal header and > consists of 3 numbers - MAJOR.MINOR.PATCH. Additionally, driver has > hard-coded minimum supported firmware version which it can work with: > > MAJOR - reflects the support on ABI level between driver and loaded > firmware, this number should be the same for driver and loaded > firmware. > > MINOR - this is the minimum supported version between driver and the > firmware. > > PATCH - indicates only fixes, firmware ABI is not changed. > > Firmware image file name contains only MAJOR and MINOR numbers to make > driver be compatible with any PATCH version. > > Signed-off-by: Oleksandr Mazur > Signed-off-by: Vadym Kochan W=1 gives me: drivers/net/ethernet/marvell/prestera/prestera_pci.c: In function prestera_fw_rev_check: drivers/net/ethernet/marvell/prestera/prestera_pci.c:590:15: warning: comparison is always true due to limited range of data type [-Wtype-limits] 590 | rev->min >= PRESTERA_SUPP_FW_MIN_VER) { | ^~