From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CAC6C433DF for ; Tue, 26 May 2020 18:57:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DCF5F2086A for ; Tue, 26 May 2020 18:57:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590519429; bh=EdGQCx22tbM38b0Jb+wVTLYFKvjDqoUuGV5CoJixVO0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=ziUsQoAHs7MFKJqYaC6GxQ9GpCqHDY/w/Q2NTpb5ln8V5VYMXE14+BdPQW99d/len 7gxByNxbFp1ruc0LdLrh4+al6WRWC1/flpKr7TacIf8s4kH2FkcuxxjWJHRoZwbfnT Uhto9DuwG+ko8fGqLKT6rcrbVjTD09TmxrhCjMt4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390033AbgEZS5I (ORCPT ); Tue, 26 May 2020 14:57:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:50194 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390011AbgEZS5D (ORCPT ); Tue, 26 May 2020 14:57:03 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F1CA120849; Tue, 26 May 2020 18:57:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590519423; bh=EdGQCx22tbM38b0Jb+wVTLYFKvjDqoUuGV5CoJixVO0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eSOLbiZRQ6kepghAMVxHej2p3PL2n9pAtooTkyA7Yefnr8orQvkY/L4pr5h5qkpe2 8GVXVME58SVf7p+zff5oByIPMQf+gr2offDwKYvWsn29FPMLHU44f6h5U2mh+DfQPP zSIBMhRVuV4yYsmdOygFzZzyHkq7O0iEuEaPi67k= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christophe JAILLET , Stable@vger.kernel.org, Jonathan Cameron , Sasha Levin Subject: [PATCH 4.4 64/65] iio: sca3000: Remove an erroneous get_device() Date: Tue, 26 May 2020 20:53:23 +0200 Message-Id: <20200526183929.129743752@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200526183905.988782958@linuxfoundation.org> References: <20200526183905.988782958@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe JAILLET [ Upstream commit 928edefbc18cd8433f7df235c6e09a9306e7d580 ] This looks really unusual to have a 'get_device()' hidden in a 'dev_err()' call. Remove it. While at it add a missing \n at the end of the message. Fixes: 574fb258d636 ("Staging: IIO: VTI sca3000 series accelerometer driver (spi)") Signed-off-by: Christophe JAILLET Cc: Signed-off-by: Jonathan Cameron Signed-off-by: Sasha Levin --- drivers/staging/iio/accel/sca3000_ring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/accel/sca3000_ring.c b/drivers/staging/iio/accel/sca3000_ring.c index 20b878d35ea2..fc8b6f179ec6 100644 --- a/drivers/staging/iio/accel/sca3000_ring.c +++ b/drivers/staging/iio/accel/sca3000_ring.c @@ -56,7 +56,7 @@ static int sca3000_read_data(struct sca3000_state *st, st->tx[0] = SCA3000_READ_REG(reg_address_high); ret = spi_sync_transfer(st->us, xfer, ARRAY_SIZE(xfer)); if (ret) { - dev_err(get_device(&st->us->dev), "problem reading register"); + dev_err(&st->us->dev, "problem reading register"); goto error_free_rx; } -- 2.25.1