From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1E26C433DF for ; Tue, 26 May 2020 19:23:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9225420888 for ; Tue, 26 May 2020 19:23:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590521028; bh=85MRjDuphd+B7adNDduYkYSTVwOmbRTDqL773PNxNGM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=mbxmOvWjhkeNEPVEexDiTNaLDCW2hiDEzHA+yEfn4fRaxi/4SsrljpYutypMPETL8 Mp5WiEb7xt9hRVHnHuEWUG7WYfFUYCI4iKtVc8pV6+w4huIWitLu5rVzkSJXzSvBKK myHahfm8tpKAa86q+nQX9ibpSK8ojwfZRleGq4xM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404517AbgEZTXr (ORCPT ); Tue, 26 May 2020 15:23:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:37724 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403917AbgEZTIn (ORCPT ); Tue, 26 May 2020 15:08:43 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3C181208B3; Tue, 26 May 2020 19:08:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590520122; bh=85MRjDuphd+B7adNDduYkYSTVwOmbRTDqL773PNxNGM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=h7Nx3MbpX1ix4BLJ+N7Zi2fEaU3HGga2ly5zXpamR0V6mT1n0ppNuQzy0SwVRU3I9 D0F1qB9RTXipmJ0LjN8oIFDgSWZebC5ZzeWuQpuA2wj4EIn32dsrRpyDt8M5VHoLAD pekjKoh5XPH/Pgq8D3vp7IGjmLBLHFr5aP9tWczM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Navid Emamdoost , John Johansen Subject: [PATCH 5.4 066/111] apparmor: Fix use-after-free in aa_audit_rule_init Date: Tue, 26 May 2020 20:53:24 +0200 Message-Id: <20200526183939.103196673@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200526183932.245016380@linuxfoundation.org> References: <20200526183932.245016380@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Navid Emamdoost commit c54d481d71c6849e044690d3960aaebc730224cc upstream. In the implementation of aa_audit_rule_init(), when aa_label_parse() fails the allocated memory for rule is released using aa_audit_rule_free(). But after this release, the return statement tries to access the label field of the rule which results in use-after-free. Before releasing the rule, copy errNo and return it after release. Fixes: 52e8c38001d8 ("apparmor: Fix memory leak of rule on error exit path") Signed-off-by: Navid Emamdoost Signed-off-by: John Johansen Signed-off-by: Greg Kroah-Hartman --- security/apparmor/audit.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/security/apparmor/audit.c +++ b/security/apparmor/audit.c @@ -197,8 +197,9 @@ int aa_audit_rule_init(u32 field, u32 op rule->label = aa_label_parse(&root_ns->unconfined->label, rulestr, GFP_KERNEL, true, false); if (IS_ERR(rule->label)) { + int err = PTR_ERR(rule->label); aa_audit_rule_free(rule); - return PTR_ERR(rule->label); + return err; } *vrule = rule;