From: Andrew Lunn <andrew@lunn.ch>
To: Dan Murphy <dmurphy@ti.com>
Cc: f.fainelli@gmail.com, hkallweit1@gmail.com, davem@davemloft.net,
robh@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH net-next v3 4/4] net: dp83869: Add RGMII internal delay configuration
Date: Wed, 27 May 2020 02:54:45 +0200 [thread overview]
Message-ID: <20200527005445.GG782807@lunn.ch> (raw)
In-Reply-To: <20200526174716.14116-5-dmurphy@ti.com>
> +static int dp83869_internal_delay[] = {250, 500, 750, 1000, 1250, 1500, 1750,
> + 2000, 2250, 2500, 2750, 3000, 3250,
> + 3500, 3750, 4000};
> +
You should make this const. Otherwise it takes up twice the space.
Andrew
prev parent reply other threads:[~2020-05-27 0:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 17:47 [PATCH net-next v3 0/4] RGMII Internal delay common property Dan Murphy
2020-05-26 17:47 ` [PATCH net-next v3 1/4] dt-bindings: net: Add tx and rx internal delays Dan Murphy
2020-05-26 17:47 ` [PATCH net-next v3 2/4] net: phy: Add a helper to return the index for of the internal delay Dan Murphy
2020-05-27 0:42 ` Andrew Lunn
2020-05-27 12:13 ` Dan Murphy
2020-05-26 17:47 ` [PATCH net-next v3 3/4] dt-bindings: net: Add RGMII internal delay for DP83869 Dan Murphy
2020-05-26 17:47 ` [PATCH net-next v3 4/4] net: dp83869: Add RGMII internal delay configuration Dan Murphy
2020-05-27 0:52 ` Andrew Lunn
2020-05-27 12:23 ` Dan Murphy
2020-05-27 13:12 ` Andrew Lunn
2020-05-27 14:51 ` Dan Murphy
2020-05-27 0:54 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200527005445.GG782807@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).