From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9227AC433E0 for ; Wed, 27 May 2020 05:23:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 78AB920776 for ; Wed, 27 May 2020 05:23:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728915AbgE0FXp (ORCPT ); Wed, 27 May 2020 01:23:45 -0400 Received: from verein.lst.de ([213.95.11.211]:48261 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725948AbgE0FXo (ORCPT ); Wed, 27 May 2020 01:23:44 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 9937168B02; Wed, 27 May 2020 07:23:41 +0200 (CEST) Date: Wed, 27 May 2020 07:23:41 +0200 From: Christoph Hellwig To: Konstantin Khlebnikov Cc: Christoph Hellwig , Jens Axboe , Minchan Kim , Nitin Gupta , dm-devel@redhat.com, linux-block@vger.kernel.org, drbd-dev@lists.linbit.com, linux-bcache@vger.kernel.org, linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/16] block: add disk/bio-based accounting helpers Message-ID: <20200527052341.GA17530@lst.de> References: <20200525113014.345997-1-hch@lst.de> <20200525113014.345997-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 25, 2020 at 03:28:07PM +0300, Konstantin Khlebnikov wrote: > I think it would be better to leave this jiffies legacy nonsense in > callers and pass here request duration in nanoseconds. jiffies is what the existing interfaces uses. But now that they come from the start helper fixing this will become easier. I'll do that as a follow on, as I'd rather not bloat this series even more.