From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A420C433E0 for ; Wed, 27 May 2020 09:00:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0CBF8207D3 for ; Wed, 27 May 2020 09:00:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="kpVwA1oo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388418AbgE0JAR (ORCPT ); Wed, 27 May 2020 05:00:17 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:60345 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388251AbgE0JAQ (ORCPT ); Wed, 27 May 2020 05:00:16 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 7B9615C01A7; Wed, 27 May 2020 05:00:15 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 27 May 2020 05:00:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=3ZRtiX lcFQeWgLraPyBZ52n+2xUg/Eap8AOdNZJnsiM=; b=kpVwA1ooWMY1GERAeJ1I4i NKmF3C7XjF1Qfzufdga2X0bvgpskSXp+zOx6hQK6BYL71jzG5WO7EOFXWoetrv9I pNuCuVz/l4Swic9Vj8ZWKJQn1Uu02uaSjISgVkLPb+iyFZ/MWXGc5da5eS2L7rJ8 1E8gKfgUsRkkCkEyFlOlXZIjFg086i2DuqcEYZUWcmsOpF4JIqly3ThvgrjbSRaM PC/2uFSsqKNoBllLv5L/hH2/GGrEMh6vX/84Bs93wEsmnQStUEftJvRjegy0LLGp TTX9PFKWupf8atAyLobnHEWkNhSfy7Pc3tmXfg3hL2/Ko1Hdn76mxe7kuGxQ37DQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedruddvgedgtdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefkughoucfu tghhihhmmhgvlhcuoehiughoshgthhesihguohhstghhrdhorhhgqeenucggtffrrghtth gvrhhnpedtffekkeefudffveegueejffejhfetgfeuuefgvedtieehudeuueekhfduheel teenucfkphepuddtledrieehrddufeelrddukedtnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepihguohhstghhsehiughoshgthhdrohhrgh X-ME-Proxy: Received: from localhost (bzq-109-65-139-180.red.bezeqint.net [109.65.139.180]) by mail.messagingengine.com (Postfix) with ESMTPA id 8F65C3060F09; Wed, 27 May 2020 05:00:14 -0400 (EDT) Date: Wed, 27 May 2020 12:00:11 +0300 From: Ido Schimmel To: Colin King Cc: Jiri Pirko , Ido Schimmel , "David S . Miller" , Jakub Kicinski , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][V2][net-next] mlxsw: spectrum_router: remove redundant initialization of pointer br_dev Message-ID: <20200527090011.GA1519147@splinter> References: <20200527081555.124615-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200527081555.124615-1-colin.king@canonical.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 27, 2020 at 09:15:55AM +0100, Colin King wrote: > From: Colin Ian King > > The pointer br_dev is being initialized with a value that is never read > and is being updated with a new value later on. The initialization > is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King Reviewed-by: Ido Schimmel Thanks