From: Mark Brown <broonie@kernel.org>
To: Saravana Kannan <saravanak@google.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
John Stultz <john.stultz@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
kernel-team@android.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] regulator: Add support for sync_state() callbacks
Date: Wed, 27 May 2020 12:17:50 +0100 [thread overview]
Message-ID: <20200527111750.GB5308@sirena.org.uk> (raw)
In-Reply-To: <20200527074057.246606-1-saravanak@google.com>
[-- Attachment #1: Type: text/plain, Size: 1192 bytes --]
On Wed, May 27, 2020 at 12:40:56AM -0700, Saravana Kannan wrote:
> When a regulator is left on by the bootloader or anything else before
> the kernel starts (let's call this a "boot on" regulator), we need to
> keep it on till all the consumers of the regulator have probed. This is
No, we don't. As ever we have no idea if there ever will be consumers -
we don't know what drivers the system is going to load, we don't know
what the intentions of the OS and system integration are and we have
zero idea why the system is in the state it's in.
> This commit adds a regulator_sync_state() helper function that takes
> care of all the "boot on" regulator clean up for any regulator driver.
> All one needs to do is add the following line to the driver struct.
None of the issues around this have *anything* to do with individual
drivers, all this is doing is forcing us to go through and add this to
every single driver which doesn't accomplish anything. Regulator
drivers have no role in this, they don't set policy, so there is no
reason why they should be aware of any of this.
Please go and look at the previous discussions of this topic, this needs
to work for other users as well.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-05-27 11:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 7:40 [PATCH v1] regulator: Add support for sync_state() callbacks Saravana Kannan
2020-05-27 11:17 ` Mark Brown [this message]
2020-05-27 17:17 ` Saravana Kannan
2020-05-27 20:34 ` Mark Brown
2020-05-27 20:36 ` Mark Brown
2020-05-28 2:16 ` Saravana Kannan
2020-05-28 13:27 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200527111750.GB5308@sirena.org.uk \
--to=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=john.stultz@linaro.org \
--cc=kernel-team@android.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).