From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0BBBC433E0 for ; Wed, 27 May 2020 11:29:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BAB9B207D3 for ; Wed, 27 May 2020 11:29:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728851AbgE0L3c (ORCPT ); Wed, 27 May 2020 07:29:32 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:57255 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725766AbgE0L3b (ORCPT ); Wed, 27 May 2020 07:29:31 -0400 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jduFO-0000sM-Co; Wed, 27 May 2020 11:29:22 +0000 From: Colin King To: Ayush Sawal , Vinay Kumar Yadav , Rohit Maheshwari , Herbert Xu , "David S . Miller" , linux-crypto@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] crypto: chelsio: remove redundant premature assignment to iv Date: Wed, 27 May 2020 12:29:22 +0100 Message-Id: <20200527112922.171745-1-colin.king@canonical.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King Variable iv is being assigned twice with the same value, the first assignment is redundant and can be removed and instead keep the latter assignment of iv as it is closer to the point it is being used. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/crypto/chelsio/chcr_ipsec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/crypto/chelsio/chcr_ipsec.c b/drivers/crypto/chelsio/chcr_ipsec.c index af961dcd317b..f9ad8c93e5ff 100644 --- a/drivers/crypto/chelsio/chcr_ipsec.c +++ b/drivers/crypto/chelsio/chcr_ipsec.c @@ -398,7 +398,6 @@ inline void *copy_esn_pktxt(struct sk_buff *skb, memset(pos, 0, len); aadiv = (struct chcr_ipsec_aadiv *)pos; esphdr = (struct ip_esp_hdr *)skb_transport_header(skb); - iv = skb_transport_header(skb) + sizeof(struct ip_esp_hdr); xo = xfrm_offload(skb); aadiv->spi = (esphdr->spi); -- 2.25.1