Hi Tiezhu, Thank you for the patch! Yet something to improve: [auto build test ERROR on clk/clk-next] [also build test ERROR on v5.7-rc7 next-20200526] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Tiezhu-Yang/clk-hisilicon-Use-correct-return-value-about-hisi_reset_init/20200525-113342 base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next config: m68k-allnoconfig (attached as .config) compiler: m68k-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot All errors (new ones prefixed by >>, old ones prefixed by <<): m68k-linux-ld: drivers/clk/hisilicon/clk.o: in function `hisi_clk_register_fixed_rate': clk.c:(.text+0xd0): undefined reference to `clk_register_fixed_rate' >> m68k-linux-ld: clk.c:(.text+0x120): undefined reference to `clk_unregister_fixed_rate' m68k-linux-ld: drivers/clk/hisilicon/clk.o: in function `hisi_clk_register_fixed_factor': clk.c:(.text+0x166): undefined reference to `clk_register_fixed_factor' >> m68k-linux-ld: clk.c:(.text+0x1ba): undefined reference to `clk_unregister_fixed_factor' m68k-linux-ld: drivers/clk/hisilicon/clk.o: in function `hisi_clk_register_mux': clk.c:(.text+0x208): undefined reference to `clk_register_mux_table' >> m68k-linux-ld: clk.c:(.text+0x210): undefined reference to `clk_register_clkdev' >> m68k-linux-ld: clk.c:(.text+0x2a8): undefined reference to `clk_unregister_mux' m68k-linux-ld: drivers/clk/hisilicon/clk.o: in function `hisi_clk_register_divider': clk.c:(.text+0x360): undefined reference to `clk_register_divider_table' m68k-linux-ld: clk.c:(.text+0x366): undefined reference to `clk_register_clkdev' >> m68k-linux-ld: clk.c:(.text+0x3f0): undefined reference to `clk_unregister_divider' m68k-linux-ld: drivers/clk/hisilicon/clk.o: in function `hisi_clk_register_gate': clk.c:(.text+0x43c): undefined reference to `clk_register_gate' m68k-linux-ld: clk.c:(.text+0x442): undefined reference to `clk_register_clkdev' >> m68k-linux-ld: clk.c:(.text+0x4c0): undefined reference to `clk_unregister_gate' m68k-linux-ld: drivers/clk/hisilicon/clk.o: in function `hisi_clk_register_gate_sep': clk.c:(.text+0x510): undefined reference to `clk_register_clkdev' m68k-linux-ld: drivers/clk/hisilicon/clk.o: in function `hi6220_clk_register_divider': clk.c:(.init.text+0x16): undefined reference to `clk_register_clkdev' m68k-linux-ld: drivers/clk/hisilicon/clkgate-separated.o: in function `hisi_register_clkgate_sep': clkgate-separated.c:(.text+0x128): undefined reference to `clk_register' >> m68k-linux-ld: clkgate-separated.c:(.text+0x176): undefined reference to `clk_register' m68k-linux-ld: drivers/clk/hisilicon/clkdivider-hi6220.o: in function `hi6220_clkdiv_set_rate': clkdivider-hi6220.c:(.text+0x26): undefined reference to `divider_get_val' m68k-linux-ld: drivers/clk/hisilicon/clkdivider-hi6220.o: in function `hi6220_clkdiv_round_rate': clkdivider-hi6220.c:(.text+0xa6): undefined reference to `clk_hw_get_parent' >> m68k-linux-ld: clkdivider-hi6220.c:(.text+0xc0): undefined reference to `divider_round_rate_parent' m68k-linux-ld: drivers/clk/hisilicon/clkdivider-hi6220.o: in function `hi6220_clkdiv_recalc_rate': clkdivider-hi6220.c:(.text+0x10a): undefined reference to `divider_recalc_rate' m68k-linux-ld: drivers/clk/hisilicon/clkdivider-hi6220.o: in function `hi6220_register_clkdiv': clkdivider-hi6220.c:(.text+0x1f8): undefined reference to `clk_register' m68k-linux-ld: drivers/clk/hisilicon/clk-hisi-phase.o: in function `clk_register_hisi_phase': clk-hisi-phase.c:(.text+0x172): undefined reference to `devm_clk_register' >> m68k-linux-ld: clk-hisi-phase.c:(.text+0x1e2): undefined reference to `devm_clk_register' --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org